Giter Club home page Giter Club logo

Comments (6)

aweary avatar aweary commented on August 23, 2024 1

Would it be worth using create-react-class for now until ES6 classes are wired up? Currently, new projects using reason-react will get the deprecation warning introduced in 15.5, without a way to get rid of it.

from reason-react.

xtuc avatar xtuc commented on August 23, 2024 1

I'm new to reasonml 👋 and would like to get this done.

What should we do with the additional dependency (create-react-class)?

  • It could be a peerDep as with React and React-dom (package.json#L22-L23) but all React app won't have create-react-class as dep.

  • Or should I add it to devDeps?

from reason-react.

rt2zz avatar rt2zz commented on August 23, 2024 1

imo it should be a regular dependency

from reason-react.

slonoed avatar slonoed commented on August 23, 2024

Hi! React remove createClass in version 16. Do you have plans on this ticket? There is create-react-class that provide migration. Maybe it can be used.
I want to help with this, but I don't know your plans.

from reason-react.

chenglou avatar chenglou commented on August 23, 2024

We'll simply wire things up under the hood by looking at how es6 classes work. cc @IwanKaramazow. It might only be a few lines change.

from reason-react.

chenglou avatar chenglou commented on August 23, 2024

Fixed in https://github.com/reasonml/reason-react

from reason-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.