Upstream canvas bindings about bs-webapi-incubator HOT 5 CLOSED

@chenglou I'm just starting to play around with the bindings from Canvas2dRe.re. The tests in https://github.com/reasonml-community/bs-webapi-incubator/blob/master/tests/canvas/canvas2d_test.re in use |> for some of the functions, but |> doesn't work consistently b/c many of the the function take the context as the first arg. I'm curious about why the context isn't always the last arg.

from bs-webapi-incubator.

I think I have a couple of bindings locally (like drawImage), I'll put up a PR today

from bs-webapi-incubator.

I took a shot at drawImage but it isn't quite right.

[@bs.send]
external drawImage :
  (
    t,
    ~image: HtmlImageElementRe.t,
    ~dx: float,
    ~dy: float,
    ~dWidth: float=?,
    ~dHeight: float=?,
    ~sx: float=?,
    ~sy: float=?,
    ~sWidth: float=?,
    ~sHeight: float=?,
    unit
  ) =>
  unit =
  "";

Not sure how to handle the image type since it can be any of the following:
An element to draw into the context. The specification permits any canvas image source (CanvasImageSource), specifically, a CSSImageValue, an HTMLImageElement, an SVGImageElement, an HTMLVideoElement, an HTMLCanvasElement, an ImageBitmap, or an OffscreenCanvas.
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/drawImage

Working though this has been very educational in learning reason / converting some JS canvas code, but if you've already done the work, i'd love to see your PR @bloodyowl

thanks!

from bs-webapi-incubator.

You can either make a separate binding for each type, use @bs.unwrap or a gadt with a phantom type. See https://github.com/glennsl/bucklescript-cookbook#bind-to-a-function-overloaded-to-take-an-argument-of-several-different-types-an-untagged-union

from bs-webapi-incubator.

I think this repo has become the de facto home of the Web API bindings. We can always reopen if there is a desire to upstream into bs-platform.

from bs-webapi-incubator.