Giter Club home page Giter Club logo

Comments (4)

glennsl avatar glennsl commented on May 27, 2024

detail is a property only available on CustomEvent, not on Event. And to implement it safely we'd have to add a type parameter to Dom.customEvent. Not sure if that's worth it, or if it's better to have consumers extend Dom.customEvent and implement their own properly typed detail accessor.

What's your use case?

from bs-webapi-incubator.

shtanton avatar shtanton commented on May 27, 2024

I'm trying to use this too, currently for web components.

I doubt it's possible to ensure safety as addEventListener can't change its type signature depending on whether it's listening for a custom event.

The best option I can think of is to accept an eventName type instead of a string for addEventListener:
type eventName = | Base(string) | Custom(string, 'a);
Or something to distinguish binding to regular events and custom events.

from bs-webapi-incubator.

glennsl avatar glennsl commented on May 27, 2024

How would you specify what 'a is?

We could just add an addCustomEventListener as well:

[@bs.send.pipe: t] external addCustomEventListener : string => (customEvent('a) => unit) => unit = "addEventListener";

But the problem remains, you still don't have a way of ensuring that 'a is a concrete type.

Apart from that, we have to consider how to construct custom events and how to transition from not having a type variable to having one, since the type actually lives in bs-platform, while the bindings live here.

from bs-webapi-incubator.

yawaramin avatar yawaramin commented on May 27, 2024

Closing as I don't see a type-safe way to get the detail type from an addEventListener handler given our current bindings. This will probably require more specialized bindings for addEventListener, that constrain the type more for custom events.

from bs-webapi-incubator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.