XMLEncodeSource is trimming XML attribute values about arsclib HOT 4 CLOSED

The issue was fixed. Thanks.

from arsclib.

Your issue is a bug and will be fixed soon, but i would like to comment on your encode code

• You need to provide your package not framework's package. encodeMaterials.setCurrentPackage(packageBlock); it will fail where going to resolve local resource id
• EncodeMaterials is resource intensive , better to initialize once if you are going to encode multiple times

from arsclib.

Your issue is a bug and will be fixed soon, but i would like to comment on your encode code

Interesting fact is that it only happened with this particular case. In other cases, such as the one below, it worked as expected:

<?xml version="1.0" encoding="utf-8"?>
<FrameLayout
  xmlns:android="http://schemas.android.com/apk/res/android"
  android:fitsSystemWindows="false"
  android:layout_width="fill_parent"
  android:layout_height="fill_parent"
  android:animateLayoutChanges="false">
  <TextView
    android:layout_gravity="center"
    android:id="@0x7f0902c2"
    android:layout_width="?0x7f0403c0"
    android:layout_height="?0x7f0403c0"
    android:text=" ">
  </TextView>
</FrameLayout>

I do not know why it happened for android:label.

• You need to provide your package not framework's package. encodeMaterials.setCurrentPackage(packageBlock); it will fail where going to resolve local resource id

It okay since it is a random binary XML file not tied to any particular package. I can see that in implementing this, you have assumed that an XML file would belong to a package. But in practice, this may not always be the case. This, of course, assumes that the local resources in the input file will be hexadecimal values.

• EncodeMaterials is resource intensive , better to initialize once if you are going to encode multiple times

Thanks. I'll keep that in mind.

from arsclib.

Check this commit

from arsclib.