Giter Club home page Giter Club logo

Comments (8)

nienn avatar nienn commented on June 29, 2024 2

On a first glance over the screenshots it seems that Sphinx 2.4 is moving from the selector div.section to section. This should be changed across all instances of div.section in the CSS.
In order to maintain combability with previous Sphinx versions the section selector should be added (not replaced) in each instance.

For example, this:

div.section p {
    margin: .75rem .5rem;
    line-height: 1.6rem;
}

Would become this:

div.section p,
section p {
    margin: .75rem .5rem;
    line-height: 1.6rem;
}

If they decided to move from div to section, which was not supported until IE9 and continued having some issues with some other browsers for a few years, then they probably updated other similar tags.

I still don't have my system ready to test multiple Sphinx versions but this is definitely something I could look over the next few days.

from blog.

astrojuanlu avatar astrojuanlu commented on June 29, 2024 1

It worked, thanks @agjohnson ! Sending PR

from blog.

stsewd avatar stsewd commented on June 29, 2024

We use ablog

https://github.com/readthedocs/blog/blob/master/requirements.txt

I think we can check if ablog is compatible with the latest version of sphinx or if we need to update our custom templates https://github.com/readthedocs/blog/tree/master/_themes/rtd-blog

from blog.

astrojuanlu avatar astrojuanlu commented on June 29, 2024

In this case, the issue seems to be in our local.css:

.postlist p.first {
    font-size: 24px;
}
div.section p {
    margin: .75rem .5rem;
    line-height: 1.6rem;
}

from blog.

astrojuanlu avatar astrojuanlu commented on June 29, 2024

There are other styling issues before-and-after, like a different margin on the articles, and for some reason different translations. I wonder if @nienn would have some time to have a look at the CSS differences 😇

from blog.

stsewd avatar stsewd commented on June 29, 2024

@nienn here we just want our blog to be compatible with sphinx version we are going to use (2.4), so no need to worry about backwards compatibility.

from blog.

nienn avatar nienn commented on June 29, 2024

@stsewd ok, I wasn't sure about that. Great to know! 😃

from blog.

agjohnson avatar agjohnson commented on June 29, 2024

Actually, the easiest fix here might be to set html4_writer=True on the sphinx config. When upgrading to Sphinx 2, html5 writer becomes the default. This should preserve the class names. I would attempt that first.

Long term, I'd see us moving this content to Pelican perhaps, and so we'd have templates/styling completely different from what we have here now. I'm +1 on limping along here for now, but any obvious fixes are good to have in the meantime.

from blog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.