Comments (8)
On a first glance over the screenshots it seems that Sphinx 2.4 is moving from the selector div.section
to section
. This should be changed across all instances of div.section
in the CSS.
In order to maintain combability with previous Sphinx versions the section
selector should be added (not replaced) in each instance.
For example, this:
div.section p {
margin: .75rem .5rem;
line-height: 1.6rem;
}
Would become this:
div.section p,
section p {
margin: .75rem .5rem;
line-height: 1.6rem;
}
If they decided to move from div
to section
, which was not supported until IE9 and continued having some issues with some other browsers for a few years, then they probably updated other similar tags.
I still don't have my system ready to test multiple Sphinx versions but this is definitely something I could look over the next few days.
from blog.
It worked, thanks @agjohnson ! Sending PR
from blog.
We use ablog
https://github.com/readthedocs/blog/blob/master/requirements.txt
I think we can check if ablog is compatible with the latest version of sphinx or if we need to update our custom templates https://github.com/readthedocs/blog/tree/master/_themes/rtd-blog
from blog.
In this case, the issue seems to be in our local.css
:
.postlist p.first {
font-size: 24px;
}
div.section p {
margin: .75rem .5rem;
line-height: 1.6rem;
}
from blog.
There are other styling issues before-and-after, like a different margin on the articles, and for some reason different translations. I wonder if @nienn would have some time to have a look at the CSS differences 😇
from blog.
@nienn here we just want our blog to be compatible with sphinx version we are going to use (2.4), so no need to worry about backwards compatibility.
from blog.
@stsewd ok, I wasn't sure about that. Great to know! 😃
from blog.
Actually, the easiest fix here might be to set html4_writer=True
on the sphinx config. When upgrading to Sphinx 2, html5 writer becomes the default. This should preserve the class names. I would attempt that first.
Long term, I'd see us moving this content to Pelican perhaps, and so we'd have templates/styling completely different from what we have here now. I'm +1 on limping along here for now, but any obvious fixes are good to have in the meantime.
from blog.
Related Issues (20)
- Add call to action in `/jobs/` page HOT 3
- Review OpenGraph images HOT 1
- Ordered lists have no style
- Marketing for build.jobs HOT 8
- Do blog post on how we scale to 500 req/s HOT 2
- June Newsletter
- Write a blog post using Metabase metrics HOT 2
- Blog post about metabase graphs of RTD/Sphinx usage HOT 3
- Write blog post about `build.commands` HOT 1
- Additional blog posts about package adoption HOT 2
- Use Plausible for analytics HOT 1
- Write blog post with a follow up for "Auto-cancelling builds ..." HOT 3
- Blog post about "shot-scraper" HOT 5
- Unclear what "back to site" is
- Adjust margins
- No pagination on front page? HOT 1
- Advice on jQuery removal HOT 1
- Use autolabel extension
- Add preview action
- Misleading section on urllib3 and OpenSSL 1.1.1 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blog.