Giter Club home page Giter Club logo

Comments (2)

davidwdan avatar davidwdan commented on May 21, 2024 2

Sounds like a good reason to drop support for PHP < 5.4 😄

from stream.

clue avatar clue commented on May 21, 2024

It looks like the first example might in fact exhibit a race condition, while the second one can be used to reproduce this always when this is an interactive terminal. Also, if you explicitly close the input pipe via php second <&-, it crashed reproducible. Once you start piping stuff into the STDIN such as echo test | php second.php things start to work again, while interactive streams such as cat | php second.php keep crashing.

I've checked for a common denominator between the affected streams with fstat() and stream_get_meta_data(), but couldn't find a reliable source. I have only observed crashs on pipe streams, but while some pipe streams crash, others work just fine.

As such, we MAY want to look into simply enabling the read buffer again for ALL pipes, as I've not observed any side-effects of this. The read buffer was originally disabled via #20, but I've not managed to reproduce the original issue with pipe streams anyway.

Keep in mind that this only affects legacy PHP < 5.4, so it's not exactly the most pressing issue.

from stream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.