In the context of React v0.4.1 in the Ratchet Websocket library (0.3.1) I encountered

Hi, take a look on <a class="issue-link js-issue-link" data-error-text="Failed to load

We believe this has been fixed as part of <a class="issue-link js-issue-link" data-err

Writing to an invalid stream creates an infinite loop of errors about stream HOT 4 CLOSED

reactphp commented on May 21, 2024

Writing to an invalid stream creates an infinite loop of errors

from stream.

Comments (4)

cboden commented on May 21, 2024

Part of this issue was on a write error Ratchet tried to send another message (lol) as pointed out in ratchetphp/Ratchet#137. That has been resolved in ratchetphp/Ratchet#200.

I still have a concern that if a write error occurs (attempting to write to a closed stream) and the developer does not take the appropriate action the resources will not be cleaned up...If !is_resource() or feof() are detected that will not change, I wonder if in addition to the error emission React should clean up the resources at that point.

from stream.

steverhoades commented on May 21, 2024

Would it make sense in this case for the stream to keep track of it's closed state? For instance:

class Stream extends EventEmitter implements ReadableStreamInterface, WritableStreamInterface
{
    public $bufferSize = 4096;
    public $stream;
    protected $readable = true;
    protected $writable = true;
    protected $closing = false;
    protected $loop;
    protected $buffer;
    protected $closed = false; //<--- NEW

    public function __construct($stream, LoopInterface $loop)
    {
        $this->buffer->on('error', function ($error) {
            if($this->closed) {
                return;
            }
            $this->emit('error', array($error, $this));
            $this->close();
        });
    }

    public function handleClose()
    {
        if (is_resource($this->stream)) {
            fclose($this->stream);
        }
        $this->closed = true;
    }
}