Comments (8)
igorw
commented on May 18, 2024
We might be able to put a trampoline inside then or resolve to keep the stack size constant.
from promise.
jsor
commented on May 18, 2024
👍
Haven't done anything in this direction. Unfortunately, i'm swamped with work at the moment. So, if anyone wants to take a stab at it....
from promise.
mtdowling
commented on May 18, 2024
Here's a trimmed down stack trace that shows where the recursion is happening:
PHP Stack trace:
PHP 1. {main}() test.php:0
PHP 2. React\Promise\Deferred->resolve() test.php:18
PHP 3. call_user_func() /react/promise/src/Deferred.php:35
PHP 4. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/Deferred.php:35
PHP 5. React\Promise\Promise->resolve() /react/promise/src/Promise.php:122
PHP 6. React\Promise\Promise->settle() /react/promise/src/Promise.php:83
PHP 7. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/Promise.php:109
PHP 8. React\Promise\FulfilledPromise->then() /react/promise/src/Promise.php:70
PHP 9. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/FulfilledPromise.php:24
PHP 10. React\Promise\Promise->resolve() /react/promise/src/Promise.php:122
PHP 11. React\Promise\Promise->settle() /react/promise/src/Promise.php:83
PHP 12. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/Promise.php:109
PHP 13. React\Promise\FulfilledPromise->then() /react/promise/src/Promise.php:70
PHP 14. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/FulfilledPromise.php:24
PHP 15. React\Promise\Promise->resolve() /react/promise/src/Promise.php:122
PHP 16. React\Promise\Promise->settle() /react/promise/src/Promise.php:83
PHP 17. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/Promise.php:109
PHP 18. React\Promise\FulfilledPromise->then() /react/promise/src/Promise.php:70
PHP 19. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/FulfilledPromise.php:24
PHP 20. React\Promise\Promise->resolve() /react/promise/src/Promise.php:122
PHP 21. React\Promise\Promise->settle() /react/promise/src/Promise.php:83
PHP 22. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/Promise.php:109
PHP 23. React\Promise\FulfilledPromise->then() /react/promise/src/Promise.php:70
PHP 24. React\Promise\Promise->React\Promise\{closure}() /react/promise/src/FulfilledPromise.php:24
from promise.
mtdowling
commented on May 18, 2024
I think @igorw is right: using a trampoline with promise resolution should be possible. It looks like bluebird uses trampolines, and here's a proof of concept promises implementation that uses trampolines: https://gist.github.com/Twisol/4526419.
from promise.
jsor
commented on May 18, 2024
I played a little bit: https://github.com/reactphp/promise/compare/queue
At least it can now run your example code :)
from promise.
jsor
commented on May 18, 2024
Since the queue implementation only reduces recursion per each promise chain, i also played with a global queue: https://github.com/reactphp/promise/compare/global-queue. It's a little bit more difficult because done() could throw exceptions which could break the queue.
I also realized, that introducing a queue opens the possibility to implement future-turn resolutions (#4).
from promise.
mtdowling
commented on May 18, 2024
Interesting. How would you envision the global queue technique working with something like React? Would it just drain the task queue on each tick?
from promise.
jsor
commented on May 18, 2024
Exactly, $this->drain() would become nextTick(function() { $this->drain() }).
from promise.
Related Issues (20)
- 2.x returned promise types HOT 3
- return promise from onFullfilled HOT 8
- Fullfilled or Rejected promise and then method HOT 9
- Is there is any way in Reactphp to run code really asynchronously HOT 1
- [RFC] Consider deprecating FulfilledPromise and RejectedPromise (mark as internal only) HOT 6
- Detecting thenable causes unwanted side effects
- ETA version 3? HOT 4
- Call promise twice HOT 2
- When serializing & later unserializing exceptions thrown by clashing function calls HOT 13
- PHP 8.0 Deprecation Notice HOT 1
- Blocking a promise from running untill another promise has completed. HOT 11
- Problem with PHP 8 HOT 3
- allSettled operator HOT 2
- QUESTION - How to test if a code is blocking or not HOT 2
- php 7.1 multiple exceptions using the pipe (|) character HOT 1
- Allow `iterable` instead of `array` for `all()`, `race()` and `any()` HOT 1
- Add example folder HOT 2
- Support Disjunctive Normal Form Types (DNF types) for PHP 8.2+
- Exception: Value of type null is not callable HOT 5
- Arguments expecting callables should describe the full signature of callables HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from promise.