Comments (7)
Thanks for reporting and you're absolutely right, this has been on my mind for a while. I'm in favor of strtolower
all the header names.
@clue what is your take on this?
from http.
Or could go for a class that behaves as an array and makes them case-insensitive
from http.
but I believe we should fix it directly in reactphp/http
Absolutely! 👍
Afaict most occurrences will be replaced with PR #41 anyway, but we should definitely keep an eye on this.
I'm in favor of strtolower all the header names.
Yeah, this should do it for now (http://php.net/array_change_key_case).
Eventually we will look into supporting PSR-7 (#28), by then we will also follow proper message semantics while preserving header case information.
FWIW, RFC 2616 has been replaced with this:
Each header field consists of a case-insensitive field name followed by […]
http://tools.ietf.org/html/rfc7230#section-3.2
from http.
I actually went ahead and implemented a fix in PR #53 since I needed a fix for a work project. Hopefully #41 gets merged soon so I can drop my fix.
from http.
Will we ever see #41? It's a year in making now (sad).
from http.
@andig It's nearing completion see #41 (comment) see the issues mentioned in that comment. You're input on those is valued 👍
from http.
I'm currently looking into this and will file a PR for the upcoming v0.4.4 release. See #103 for the first step here.
from http.
Related Issues (20)
- Memory leak? HOT 8
- Possible memory leak when using Queue HOT 6
- HTTP client: Expose maximum time to keep alive idle connection with persistent connections HOT 5
- Cannot create socket server HOT 3
- HTTP client on specific network shows poor performance HOT 5
- HTTP client: Simplify HTTP file uploads and submitting forms HOT 1
- EmptyBodyStream as request body not working HOT 3
- Regression: object with __toString no longer being accepted as request body in Browser post HOT 1
- getFragment() returns empty string, username:password@hostname not supported HOT 1
- Unable to properly cancel request (Browser) HOT 8
- URI Behind Reverse Proxy Incorrect Scheme HOT 5
- Laravel + websockets: Unhandled promise rejection with TypeError HOT 1
- MAX_CHUNK_HEADER_SIZE size increase HOT 4
- Random HTTP Requests don't resolve HOT 2
- Body Stream Closes when running Browser Request HOT 3
- The psr/http-message v2 is not supported HOT 1
- Add support for psr/http-message v2
- Memory leak when using persistent connections HOT 3
- Roadmap to reactphp/http v3
- ServerInstance socket not closing on unexpected program termination or loop stop HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from http.