periodic timer with the interval of zero about event-loop HOT 4 CLOSED

The ExtEvLoop implementation did not take into account the adjusted min bounded $interval stored in Timer. EvTimer was being initialised with a repeat value of 0, completing after the first invocation of the timer. A simple patch is proposed in PR #243

from event-loop.

To be honest, I'm not sure, adding a periodic timer with an interval of 0 is not an expected thing to do. Theoretically, it should trigger every loop iteration, creating a very busy loop, and completely utilizing a full CPU core.

I'm assuming you want to have that function called a lot, and guessing 100 times a second is enough then using 0.01 should do the trick.

from event-loop.

To be honest, I'm not sure, adding a periodic timer with an interval of 0 is not an expected thing to do. Theoretically, it should trigger every loop iteration, creating a very busy loop, and completely utilizing a full CPU core.

I'm assuming you want to have that function called a lot, and guessing 100 times a second is enough then using 0.01 should do the trick.

in the path : React\EventLoop\Timer\Timer

const MIN_INTERVAL = 0.000001;

if ($interval < self::MIN_INTERVAL) {
    $interval = self::MIN_INTERVAL;
}

There is a piece of logic in the timer class constructor that if the time is less than the minimum time, the minimum time is selected. But by selecting zero time, the timer no longer works periodically. And calls the callback only once

Even if I choose very small number instead of zero, the timer works periodically

$this->loop->addPeriodicTimer(0.0000000000000000000001, function () {
   echo "time is ticking...";   // this works periodically 
});

This only happens when ExtEvLoop is used and StreamSelectLoop does not have this problem.

from event-loop.

@my-random-username Thanks for reporting what sounds like a bug in the ExtEvLoop event loop implementation.

I agree that using a zero interval is rarely useful but may still happen in practice. As a counter measure, it looks like this is easy to work around by using a non-zero interval as suggested above.

I don't currently have access to a system with ext-ev installed, but if what you're saying is correct than I would consider this to be a (minor) defect. If anybody feels like picking this up, this sounds like a rather small fix, so PRs to address this are much appreciated!

from event-loop.