ComposableThroughputTests: not clear what is being tested - created Composable does not do anything about reactor HOT 4 CLOSED

I'll try and take a look at this later today. Doing some remodeling at the house this weekend. :)

Sent from my iPhone

On May 18, 2013, at 9:34 AM, Roman Stepanenko [email protected] wrote:

The test creates this Composable (System.out.println are mine):

private Composable<Integer> createComposable(Dispatcher dispatcher) {
    return new Composable<Integer>(dispatcher)
            .map(new Function<Integer, Integer>() {
                @Override
                public Integer apply(Integer integer) {
                    System.out.println("mapping: "+integer);
                    return integer;
                }
            })
            .reduce(new Function<Composable.Reduce<Integer, Integer>, Integer>() {
                @Override
                public Integer apply(Composable.Reduce<Integer, Integer> r) {
                    int last = (null != r.getLastValue() ? r.getLastValue() : 1);
                    System.out.println("reducing: last value: "+r.getLastValue()+", nextValue: "+r.getNextValue());
                    return last + r.getNextValue();
                }
            })
            .consume(new Consumer<Integer>() {
                @Override
                public void accept(Integer integer) {
                    System.out.println("consuming: "+integer);
                    latch.countDown();
                }
            });
}

When I run the test, only consume method prints to console. Map and Reduce do not do anything.

Not sure what the test it trying to test - just speed of consuming (then kill map and reduce) or cumulative processing as well (then there is a bug somewhere because map and reduce don't produce any output)

—
Reply to this email directly or view it on GitHub.

from reactor.

I guess you also have seen the others composable tests if you're interested by quick logic examples:

• https://github.com/reactor/reactor/blob/master/reactor-groovy/src/test/groovy/reactor/groovy/GroovyComposableSpec.groovy
• https://github.com/reactor/reactor/blob/master/reactor-core/src/test/java/reactor/core/ComposableTests.java

from reactor.

There should be access to an initial Composable that will accept the first value. So the first reference should be Composable<Integer> cInt = new Composable<>(dispatcher). Then call map etc.. from that cInt. When the logic is ready to be run, call cInt.accept(intValue) which starts the whole processing chain.

from reactor.

Got it, working now, thank you for quick turnaround. Please fix the test later when you get a chance

from reactor.