Giter Club home page Giter Club logo

Comments (6)

janchristian-haddorp avatar janchristian-haddorp commented on September 28, 2024 1

@almogtavor, first you can try replacing ReactiveKafkaProducerTemplate by KafkaSender. This allows to confiure metrics and observation. Will be available on upcoming Reactor Kafka release.

@Bean
public SenderOptions<String, OutputPojo> kafkaProducerOptions(
        @Value("${spring.kafka.consumer.topic}") String outputTopic,
        KafkaProperties properties) {
    Map<String, Object> props = properties.buildProducerProperties();

    return SenderOptions.create(props);
}

@Bean
public KafkaSender<String, OutputPojo> kafkaSender(
        SenderOptions<String, OutputPojo> kafkaSenderOptions,
        ObservationRegistry registry) {
    return KafkaSender.create(kafkaSenderOptions
            .withObservation(registry));
}

Beside this using libs on your sample project look slightly outdated. Not sure if this still fits together...

from reactor-kafka.

patpatpat123 avatar patpatpat123 commented on September 28, 2024

upvoting this

from reactor-kafka.

almogtavor avatar almogtavor commented on September 28, 2024

@janchristian-haddorp thank you very much. I didn't know about the .withObservation method so I'll try it and update my deps to boot 3 etc. Can you refer to my 3 points I struggled with? Have you tried tracing the parallel scheduler? Buffers?

from reactor-kafka.

artembilan avatar artembilan commented on September 28, 2024

See an Observation support in the upcoming release: https://github.com/reactor/reactor-kafka/blob/main/src/docs/asciidoc/api-guide.adoc#micrometer-observation.

The rest of questions about parallel scheduler and buffers are out of this project scope.
See general Reactor docs:
https://projectreactor.io/docs/core/release/reference/#_observation
https://projectreactor.io/docs/core/release/reference/#context.propagation

The Otel API is definitely out of our reach at all.

Not sure what else you would like to see from the scope of this project...

from reactor-kafka.

michalwilk96 avatar michalwilk96 commented on September 28, 2024

@artembilan what is the usage of "user.receiver" inside KafkaRecordReceiverContext? (https://github.com/reactor/reactor-kafka/blob/main/src/docs/asciidoc/api-guide.adoc#micrometer-observation)

from reactor-kafka.

artembilan avatar artembilan commented on September 28, 2024

See KafkaRecordReceiverContext source code: https://github.com/reactor/reactor-kafka/blob/main/src/main/java/reactor/kafka/receiver/observation/KafkaRecordReceiverContext.java#L37

So, that is a receiverId - a unique id for the reactor.kafka.client.id tag in the target span.
Logical identifier of your Reactor Kafka service.

from reactor-kafka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.