Giter Club home page Giter Club logo

Comments (6)

akarnokd avatar akarnokd commented on May 18, 2024

Two options:

  • Release the scheduler after the terminal event has been emitted. Drawback: potentially longer retention.
  • Make sure the Future.cancel() is called with false if the current thread happens to be the thread running the task. Drawback: task instance size increase, more instructions before the task body is run.

from reactor-core.

smaldini avatar smaldini commented on May 18, 2024

I actually wonder which interrupt @sskrla is referring to since it should be the current dispatcher strategy for SchedulerGroup at least. I guess since it was referring to Fluxion which offered dispachOn(ExecutorService) as in RSC it is this one.

EDIT: yes it was the ExecutorService scheduler implementation.

from reactor-core.

smaldini avatar smaldini commented on May 18, 2024

As a second issue, adding ExecutorService direct support to Flux/Mono should be considered, opened #51.

from reactor-core.

smaldini avatar smaldini commented on May 18, 2024

@akarnokd do you know if we face that issue still in RSC ExecutorService support ?

from reactor-core.

akarnokd avatar akarnokd commented on May 18, 2024

Due to a recent update, Rsc's observeOn shuts down the worker after onComplete has been delivered. At that point, all that's left is the end of the wrapper action on the scheduler and no user code can be executed that would throw on an interrupted thread. Otherwise, it still interrupts itself at that point which adds some overhead. I can work around that if necessary.

from reactor-core.

smaldini avatar smaldini commented on May 18, 2024

I'll sync it as it for now thanks @akarnokd .

from reactor-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.