Giter Club home page Giter Club logo

Comments (7)

vpriscan avatar vpriscan commented on July 18, 2024 2

RxKotlin 3.0.0 is released with package changed to io.reactivex.rxjava3.kotlin. We apologize to RxKotlin 3.0.0-RC1 users for inconvenience caused by the change.

from rxkotlin.

lwasyl avatar lwasyl commented on July 18, 2024 1

I'd argue for changing the package again, to io.reactivex.rxjava3.kotlin, before the final release. For one consistency will help with clarity in the long term, and changing this before the release will only be confusing/an issue for people who updated to an RC version early. But also io.reactivex.rxkotlin3 suggests compatibility with Kotlin 1.3 and not RxJava3. Perhaps with Kotlin 1.4 release there'll be need to have a separate artifact for it, in which case io.reactivex.rxjava3.kotlin4 would be available. Not sure how likely this scenario is, but anyway consistency with other rxjava3 groups feels enough to warrant the change

from rxkotlin.

mickverm avatar mickverm commented on July 18, 2024 1

I'd change just for the consistency, it makes RxJava3 feel like a complete ecosystem.

from rxkotlin.

lwasyl avatar lwasyl commented on July 18, 2024 1

I don't think package rxkotlin3 suggests Kotlin 1.3. It's not "Kotlin 3".

That was a stretch, I admit :) I just see how version number near kotlin instead of rxjava might be confusing

from rxkotlin.

vpriscan avatar vpriscan commented on July 18, 2024 1

You have convinced me that package io.reactivex.rxjava3.kotlin is better. Reason is, yes, RxKotlin is just a tiny extension over RxJava, just like RxAndroid is. Having the mentioned package names contributes to the overall feeling that all RxJava ecosystem components are designed to work together hand in hand.
This does look nice:

import io.reactivex.rxjava3.flowables...
import io.reactivex.rxjava3.observables...
import io.reactivex.rxjava3.android...
import io.reactivex.rxjava3.kotlin...

If RxKotlin is ever rewritten in pure Kotlin, be it for JVM, JS, Native or all of them, then io.reactivex.rxkotlin<version> would make perfect sense.

from rxkotlin.

vpriscan avatar vpriscan commented on July 18, 2024

It is already changed from io.reactivex.rxkotlin to io.reactivex.rxkotlin3, and my opinion is that changing it again would cause confusion among users (even though it is a RC).

from rxkotlin.

vpriscan avatar vpriscan commented on July 18, 2024

@lwasyl I don't think package rxkotlin3 suggests Kotlin 1.3. It's not "Kotlin 3".

But consistency with other RxJava3 namings does provide warranty.

@thomasnield can you decide?

from rxkotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.