Comments (7)
RxKotlin 3.0.0 is released with package changed to io.reactivex.rxjava3.kotlin. We apologize to RxKotlin 3.0.0-RC1 users for inconvenience caused by the change.
from rxkotlin.
I'd argue for changing the package again, to io.reactivex.rxjava3.kotlin
, before the final release. For one consistency will help with clarity in the long term, and changing this before the release will only be confusing/an issue for people who updated to an RC version early. But also io.reactivex.rxkotlin3
suggests compatibility with Kotlin 1.3 and not RxJava3. Perhaps with Kotlin 1.4 release there'll be need to have a separate artifact for it, in which case consistency with other rxjava3 groups feels enough to warrant the changeio.reactivex.rxjava3.kotlin4
would be available. Not sure how likely this scenario is, but anyway
from rxkotlin.
I'd change just for the consistency, it makes RxJava3 feel like a complete ecosystem.
from rxkotlin.
I don't think package rxkotlin3 suggests Kotlin 1.3. It's not "Kotlin 3".
That was a stretch, I admit :) I just see how version number near kotlin
instead of rxjava
might be confusing
from rxkotlin.
You have convinced me that package io.reactivex.rxjava3.kotlin
is better. Reason is, yes, RxKotlin is just a tiny extension over RxJava, just like RxAndroid is. Having the mentioned package names contributes to the overall feeling that all RxJava ecosystem components are designed to work together hand in hand.
This does look nice:
import io.reactivex.rxjava3.flowables...
import io.reactivex.rxjava3.observables...
import io.reactivex.rxjava3.android...
import io.reactivex.rxjava3.kotlin...
If RxKotlin is ever rewritten in pure Kotlin, be it for JVM, JS, Native or all of them, then io.reactivex.rxkotlin<version>
would make perfect sense.
from rxkotlin.
It is already changed from io.reactivex.rxkotlin to io.reactivex.rxkotlin3, and my opinion is that changing it again would cause confusion among users (even though it is a RC).
from rxkotlin.
@lwasyl I don't think package rxkotlin3 suggests Kotlin 1.3. It's not "Kotlin 3".
But consistency with other RxJava3 namings does provide warranty.
@thomasnield can you decide?
from rxkotlin.
Related Issues (20)
- RxKotlin is not resolved properly after updating Gradle to 3.4.0 HOT 17
- Admin Help - Adding a Collaborator HOT 5
- withLatestFrom() build error with RxKotlin 2.4.0 HOT 1
- Do we need to call onComplete() of subject in onDestroy() method of activity ? HOT 2
- Add mapNotNull extension HOT 1
- RxJava 3 support HOT 6
- Question about contributing: code styles
- Compilation error HOT 2
- Type mismatch for return type
- observeOn(AndroidSchedulers.mainThread()) HOT 2
- zipWith and Kotlin 1.4.0 HOT 4
- Add support for doOnLifecycle.
- Singles.zip does not invoke onError when one of the stream throws error
- issue with the indirect dependency component reactive-stream License
- `delay` extension reduces type detection (for `Observable.create` series)
- Update Kotlin version to use Duration?
- Kotlin multiplaform support HOT 1
- Issues with generics in Kotlin 1.8.0
- extensions for coroutine flow HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rxkotlin.