Giter Club home page Giter Club logo

Comments (6)

jjordy avatar jjordy commented on May 12, 2024

Another note specifically what happens is when that when I browse the the problem page it works fine when i browse there but as soon as i make a code change or refresh the page it freezes during the suspense loading. and causes the tab to crash.

from data-client.

jjordy avatar jjordy commented on May 12, 2024

After further investigation I do believe this is related to Code splitting I just need to figure out exactly what is causing it. I will try to put together an example to see if this is related to the library or specifically my code.

Thanks,

Jordy

from data-client.

ntucker avatar ntucker commented on May 12, 2024

https://github.com/coinbase/rest-hooks/blob/master/src/state/NetworkManager.ts#L33

That error is sent as a rejection to any open promises when cleanup() is called. This happens on unmount of <RestProvider />.

So I believe the problem is your <RestProvider/> is unmounting, which will not maintain state.

I would say your best bet is probably not having the <RestProvider/> part of the code hotreload. Alternatively you could look into using redux https://resthooks.io/docs/guides/redux#docsNav and making sure your store persists and only the reducers are hot reloaded.

from data-client.

jjordy avatar jjordy commented on May 12, 2024

Ok this makes sense do you think that would also cause the issue I'm seeing of it just freezing in the loading state and blowing up the tab either due to a memory leak / issue in my code or somewhere else?

from data-client.

jjordy avatar jjordy commented on May 12, 2024

I created a reproduction and was unable to reproduce. This is something inside my code as i was able to deeply nest lazy loaded routes in conjunction with useResource with no freezing issues.

Sorry for the trouble Thanks for the insight.

from data-client.

ntucker avatar ntucker commented on May 12, 2024

I would be interested to see if you could consistently reproduce this. It could be a bug in react, or an edge case in rest-hooks that could be ironed away.

from data-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.