Comments (6)
Another note specifically what happens is when that when I browse the the problem page it works fine when i browse there but as soon as i make a code change or refresh the page it freezes during the suspense loading. and causes the tab to crash.
from data-client.
After further investigation I do believe this is related to Code splitting I just need to figure out exactly what is causing it. I will try to put together an example to see if this is related to the library or specifically my code.
Thanks,
Jordy
from data-client.
https://github.com/coinbase/rest-hooks/blob/master/src/state/NetworkManager.ts#L33
That error is sent as a rejection to any open promises when cleanup() is called. This happens on unmount of <RestProvider />.
So I believe the problem is your <RestProvider/> is unmounting, which will not maintain state.
I would say your best bet is probably not having the <RestProvider/> part of the code hotreload. Alternatively you could look into using redux https://resthooks.io/docs/guides/redux#docsNav and making sure your store persists and only the reducers are hot reloaded.
from data-client.
Ok this makes sense do you think that would also cause the issue I'm seeing of it just freezing in the loading state and blowing up the tab either due to a memory leak / issue in my code or somewhere else?
from data-client.
I created a reproduction and was unable to reproduce. This is something inside my code as i was able to deeply nest lazy loaded routes in conjunction with useResource with no freezing issues.
Sorry for the trouble Thanks for the insight.
from data-client.
I would be interested to see if you could consistently reproduce this. It could be a bug in react, or an edge case in rest-hooks that could be ironed away.
from data-client.
Related Issues (20)
- ReferenceError: Can't find variable: endpoint after upgrading from 3.0.3 to 5.1.1 HOT 21
- bug: missing typing for body when using entity class HOT 3
- v6 migration guide HOT 4
- RFC: Retry on 'soft' errors + sideEffect false HOT 3
- Objects and properties sometimes undefined from useSuspense HOT 18
- Object.hasOwn is not a function on safari v14.1 HOT 2
- Missing type inference for controller.fetch HOT 20
- Pagination with infinite scroll example HOT 4
- Docs: Thinking in Suspense HOT 1
- Using function to define entities HOT 2
- useLoading is incompatible with React.StrictMode HOT 1
- Adding a child list item and updating the parent list HOT 4
- React Hook cannot be called in a class component. HOT 2
- Question: Is useCache supposed to automatically return the updated cache data after cache change? HOT 2
- Cannot import makeCacheProvider in rest-hook version 7 for hook unit tests HOT 6
- Action Required: Fix Renovate Configuration
- Unexpected behavior when an entity has many entities. HOT 1
- Support Next.js app router HOT 4
- add create member to resource class HOT 8
- Allow to override Endpoint url method to handle objects in query params HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data-client.