Custom shapes with different getFetchKey about data-client HOT 3 CLOSED

Hi, isn't there a more direct approach to achieve this? Seems a little unnecessary and ugly to repeat the URL, even more if you have to take params into account, like this:

static searchShape() {
  return {
    ...super.listShape(),
    getFetchKey: params =>
      `${this.urlRoot}/find?${new URLSearchParams(params).toString()}`,
    fetch: (params, body) =>
      this.fetch(
        'get',
        `${this.urlRoot}/find?${new URLSearchParams(params).toString()}`,
        body
      )
  };
}

from data-client.

You'll need to also override the fetch function of FetchShape. https://resthooks.io/docs/guides/endpoints#custom-get is a good example. I didn't outline this in the migration blog post so I'll add that soon.

export class ExampleResource extends BaseResource {
  static urlRoot = 'v1/examples/';

  static customShape() {
    return {
      ...super.createShape(),
      getFetchKey: () => 'v1/examples/custom/',
      fetch: (params: {}, body?: Readonly<object>) => {
        return this.fetch('post', `v1/examples/custom/`, body);
      },
    };
  }
}

What actually happened is getFetchKey() is just used to lookup in the request part of the normalized cache. fetch() no longer calls getUrl() or any other function to generate its url - so you'll have to override it when customizing the url.

from data-client.

Ah ok. That seems to be working now. Thanks! Feel free to close.

from data-client.