Comments (4)
See https://github.com/ongoworks/reaction-core/commit/9a19bfdf2e79
from reaction.
@aldeed your change just shows the existing "placeholder" image when uploading correct? Should we make this an actual progress bar?
from reaction.
Yep, I just did a quick fix so that things didn't jerk around on the screen. I think ideally I'd prefer a box the same size as the eventual image, but with a circular/piechart progress indicator in the middle. First it would show "Uploading..." with circular progress and then switch to "Storing..." with circular progress. Another option that we have been wanting to add to CFS is instant client-side preview during upload/storage. You might even want the client-side preview image shown but with the progress indicators overlaid until the real file is shown.
All of these ideas could actually be implemented in the cfs-ui
package or other CFS packages, and then just used here.
from reaction.
Closing, existing progress bar works in image gallery. @mikemurray @kieckhafer will review again when we next update image gallery.
from reaction.
Related Issues (20)
- Make time between checking for active promotions an env var
- Location Inventory BE HOT 8
- Location Inventory BE
- Test upgrading existing 4.x db to Mongo 5
- Typo in promotion removal message HOT 1
- Fulfillment Strategies
- When promotions conflict due to stackability use the promotion that produces the largest discount amount
- Allow shops to issue and use API keys for endpoints
- Stackability Resolution Strategy
- Refactor functions that collect quotes from various fulfillment methods
- Move the Schema extension step from fulillment-type plugin to individual plugins
- Store Pickup BE
- Store Pickup BE
- Failed to initialize a MongoDB replica set. HOT 1
- Allow configurable password reset URL HOT 1
- The CLI does not work - dependencies are not published to npm HOT 6
- Sponsored issue: Shopping Cart Data Sync Issue Affecting Checkout Page HOT 3
- change "Twitter" to "𝕏 (Twitter)" in README.md HOT 4
- Node versioning issue HOT 5
- Keep Get 'It looks like you have not run `npm install` in this directory' Error Even If I Already Do the NPM Install
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reaction.