Giter Club home page Giter Club logo

Comments (3)

facultymatt avatar facultymatt commented on May 28, 2024

I discovered this is because of filteredSuggestions https://github.com/prakhar1989/react-tags/blob/master/lib/reactTags.js#L81-L85 and maybe other functions which call this.

This behavior makes sense sometimes, but in all cases its not ideal. For example in my case the filtering is done via an API call so my suggestions list is ready to go - the extra filtering step produces unexpected results.

Is is possible to make this an option so the user can provide their own filter function? What are some other good solutions?

from react-tags.

facultymatt avatar facultymatt commented on May 28, 2024

Would be great if the user could override filteredSuggestions to supply a custom matching function. Initially I thought i was customizable but I was mistaken.

from react-tags.

prakhar1989 avatar prakhar1989 commented on May 28, 2024

Sounds like a good idea. I feel that making the filter function, customizable would be useful, but I'm not sure how the API should look like. My understanding is that most users would not want to customize that function and hence there should be a reasonable way of making the default available.

I'll see how others are doing it and in the meantime if you have any ideas, feel free to share.

from react-tags.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.