Upgrade from 0.61.5 -> 0.62.0 causes git issues on new check out about rn-diff-purge HOT 6 CLOSED

Thanks @pvinis

I actually think (have not tested) that the bat rule should be in a template/_gitattributes in facebook/react-native.

gradlew.bat is committed to the facebook/react-native with crlf line endings, but when I try to create a new project from the template on mac, I get gradlew.bat with lf line endings. And as there's no .gitattributes in the new project (from the default template), the file would be converted to lf line endings anyway on staging/commit.

from rn-diff-purge.

@pvinis This i blocking npx react-native upgrade for me as well.

As I see it we could fix it in 2 ways:

1. rewrite the history/move tags in this repository to ignore/move .gitattributes
2. Add logic to handle the issue in https://github.com/react-native-community/cli/blob/master/packages/cli/src/commands/upgrade/upgrade.ts

Do you have any preference on a solution?

from rn-diff-purge.

I commented on it here react-native-community/upgrade-support#71 (comment).

Since I don't use Windows for developing RN stuff, I am not too interested or too capable to fix this at this point. I tried to fix it and it caused problems for others.

I'm happy to help if I can, but yea, feel free to work on this in any way you think is best.

I would need to spend time to refamiliarize myself with the problem and for the next month I can't do that unfortunately, but I'm happy to chat about it and or see the problem or a video of it or whatever and suggest solutions. If you feel any of these two makes the most sense, do it 👍. The RN team and community are always welcoming new fixes in tooling! I know I love these :D

from rn-diff-purge.

@pvinis Do you have a reference for the original reason to add the .gitattributes file? It seems like something that should be fixed in the official react native template

from rn-diff-purge.

I would say it's facebook/react-native#28274

from rn-diff-purge.

sounds like that would fix things then. maybe this exact change can be made into a PR for the RN repo. add a template gitattr and fix the line endings, then things should work fine. we can remove the gitattr from rndiffpurge after that 👌. good investigation.

from rn-diff-purge.