Giter Club home page Giter Club logo

Comments (10)

Titozzz avatar Titozzz commented on May 27, 2024 2

Confirming it works 🎉

from cli.

thymikee avatar thymikee commented on May 27, 2024 1

The template changed to using the short (?) form, .MainActivity, which is what the code currently assumes.

Yeah and I think that's why this slipped through. Your suggestion to fix it makes sense to me, send #2269 with this change. Let's see what @cortinico says about it

from cli.

thymikee avatar thymikee commented on May 27, 2024 1

Thank you for testing! Will release it on Monday

from cli.

tido64 avatar tido64 commented on May 27, 2024

cc @kelset @thymikee

from cli.

edodusi avatar edodusi commented on May 27, 2024

I can confirm I see the same error

System:
  OS: macOS 14.2.1
  CPU: (8) arm64 Apple M1
  Memory: 62.17 MB / 8.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.10.0
    path: ~/.nvm/versions/node/v20.10.0/bin/node
  Yarn:
    version: 1.22.21
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.2.3
    path: ~/.nvm/versions/node/v20.10.0/bin/npm
  Watchman:
    version: 2023.12.04.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.11.3
    path: /Users/edoardodusi/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK:
    API Levels:
      - "28"
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
      - "34"
    Build Tools:
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 32.0.0
      - 32.1.0
      - 33.0.0
      - 33.0.0
      - 33.0.1
      - 34.0.0
    System Images:
      - android-28 | Google APIs ARM 64 v8a
      - android-30 | Intel x86 Atom_64
      - android-32 | Google APIs ARM 64 v8a
      - android-34 | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2023.1 AI-231.9392.1.2311.11076708
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.9
    path: /usr/bin/javac
  Ruby:
    version: 3.3.0
    path: /Users/edoardodusi/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

from cli.

thymikee avatar thymikee commented on May 27, 2024

I believe this is also what happened to @Titozzz as well. What's the activity defined in your AndroidManifest.xml @tido64 @edodusi?

from cli.

tido64 avatar tido64 commented on May 27, 2024

I believe this is also what happened to @Titozzz as well. What's the activity defined in your AndroidManifest.xml @tido64 @edodusi?

It's a fully qualified name, com.microsoft.reacttestapp.MainActivity. The fix above checks for it before doing concatenations.

Edit: The template changed to using the short (?) form, .MainActivity, which is what the code currently assumes.

from cli.

cortinico avatar cortinico commented on May 27, 2024

Let's see what @cortinico says about it

Thanks for looking into this. #2269 looks like the correct approach 👍

from cli.

Titozzz avatar Titozzz commented on May 27, 2024

Forwarding to @jblarriviere who's gonna test right now if that fixes our issue :)

from cli.

tido64 avatar tido64 commented on May 27, 2024

Thanks for the quick turnaround!

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.