Giter Club home page Giter Club logo

Comments (5)

bentatum avatar bentatum commented on May 18, 2024

We can totally discuss doing this, but for now you should be able to accomplish whatever you need to do using composition.

<div class="ri ri-fa-star">
  <svg />
</div>

from react-icons.

bentatum avatar bentatum commented on May 18, 2024

@gorangajic thoughts on this?

from react-icons.

brillout avatar brillout commented on May 18, 2024

It's actually what I'm doing right now but wrapping each icon individually is a bit cumbersome.

It seems to me that there are more important tickets though, e.g. #66

Thanks @bentatum for your work on this, I like this library a lot

from react-icons.

bentatum avatar bentatum commented on May 18, 2024

I see what you mean. We'll keep it on the list.

For now, you could also create a component that does the wrapping once for you.

// CustomIcon.js
import Icon from 'react-icons/lib/io/arrow'
export default ({ className, ...props }) =>
  <div className={className}>
    <Icon {...props} />
  </div>

and then use it like this:

// App.js
import Icon from './CustomIcon'
export default () => <Icon className='ri ri-fa-star' />

from react-icons.

bentatum avatar bentatum commented on May 18, 2024

I'm going to close this for now. Feel free to submit a PR to propose any desired functionality you may have and we'll consider it!

from react-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.