Giter Club home page Giter Club logo

Comments (4)

rdoeffinger avatar rdoeffinger commented on June 21, 2024

Sorry, I had missed this somehow.
It seems a bit overkill to me for just a comment, wouldn't it be reasonable to just replace anything problematic with a space instead for much simpler code?

from iec16022.

geusebi avatar geusebi commented on June 21, 2024

To me it's reasonable enough as long as the resulting EPS is valid and readable.
I wrote the code this way just to stick to the language reference.
Replacing \n and \f with spaces is a good compromise.

I can update the PR tomorrow if you want me to.

from iec16022.

rdoeffinger avatar rdoeffinger commented on June 21, 2024

Thanks for the offer, but I pushed my own version of it in commit 712ca1d
I thought it safest to remove all control characters, and to do it in a way that also works for the other output formats like PNG.
I actually meant to credit you in the commit message for finding it and proposing the original solution but forgot in the end, sorry.
Great if you can test it.
Re-open if there's any issue/concern with it.

from iec16022.

geusebi avatar geusebi commented on June 21, 2024

I'll test it during the weekend but it already looks good to me.
Many thanks for your work and for thinking to credit me, no problem if you forgot. That's still a nice gesture

from iec16022.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.