[feat] Ordinal parameter to return only suffix about journalize HOT 5 CLOSED

Hah yeah know what you mean! 😅

I gave it a pass and honestly I think it's fine! This isn't really adding all that many extra bytes other than the additional export of ordinalsuffix. I didn't add much new code to pull it off — I extracted the suffix stuff out of ordinal and now ordinal uses ordinalsuffix internally.

from journalize.

It would also involve some logic to check that spellOutOrdinals and onlySuffix are not simultaneously true. With the example code above, though, spellOutOrdinals takes precedence, as it is originally written.

from journalize.

Hey @sawyerclick — I think this is a great idea!

For better or worse I've been pretty consistent about not having the methods of journalize have extra parameters and I would like to keep it that way if possible. What do you think about instead adding this functionality as a new function? Perhaps journalize.ordinalsuffix()?

Then we could make ordinal use that for its suffix logic and surface both paths without a breaking change.

from journalize.

That works swell! I'm happy to take the first bite at creating this, unless you have a hankering for it.

ordinalSuffix would reuse the same arrays you have up top, so we could move those to a shared file. I see the final being something like this, following a lot of the smart logic in the original:

// `ordinals` here represents an object in
// which we can store the shared arrays/logic
// between ordinal and ordinalSuffix
import { isInteger, isNil, ordinals } from './utils';

export default function ordinalSuffix(val) {
  // if `val` is undefined or null, return an empty string
  if (isNil(val)) return '';

  const convertedVal = +val;

  // if `convertedVal` is not an integer, return `val`
  if (!isInteger(convertedVal)) return '';

  // if `convertedVal` is 11, 12 or 13, English gets weird
  if (ENGLISH_ORDINAL_EXCEPTIONS.indexOf(convertedVal % 100) > -1) {
    return SUFFIXES[0];
  }

  return SUFFIXES[convertedVal % 10];
}

from journalize.

After some thought, I wonder if it's worth the extra bytes in being its own function or existing outside of ordinal.js. The suffix can essentially be accessed via ordinal(12).slice(-2), and the param was merely a convenience. I'm torn between "yes! this should exist to make it easier" and "no! that's convenience at the sake of bloat and overhead. something native exists!"

from journalize.