Move to guzzle about razorpay-php HOT 8 CLOSED

Makes sense. I need to read up a bit more on the nuance, but the idea was to use httplug.

from razorpay-php.

The reason we can rely better on httplug is because it gives users flexibility to switch between implementations. This is important in case you have other libraries that rely on a specific guzzle version, for eg.

from razorpay-php.

May I suggest not using Guzzle directly. Relying on an implementation is never good. That is why you should use HTTPlug which is an abstraction over libraries like Guzzle.

from razorpay-php.

@nemo

Should this be a major version upgrade?
I don't think so for the user nothing is changing, only internals are

Decide between guzzle 5 and 6 -> Even I would prefer guzzle 6
https://www.reddit.com/r/PHP/comments/37llgz/which_version_of_guzzle/
even for other projects either they have moved to 6 or planning to,

If we go with 6, do we keep supporting the older requests releases
can you clarify

guzzle 6 have 3 dependencies guzzlehttp/psr7, guzzlehttp/promises, psr/http-message

How to handle the httplug requirement
what do you mean by this ??

from razorpay-php.

Version: I'm not entirely sure. If the upgrade is seamless, then minor upgrade should do. However, if people are likely to face dependency issues while upgrading, a major upgrade might make more sense.

Old Releases: If for some reason, someone is unable to upgrade, do we keep supporting the older releases? Or force people to upgrade?

HTTPlug: Using httpplug means that we can let the library users decide on a different implementation. httplug is an interface that says how to make requests. Various other libraries implement it, including guzzle.
That way, if someone is using an older version of guzzle, or some other request library, it would still work with it.

from razorpay-php.

Version: let's decide on version at the end, as you mentioned if upgrade is seamless then minor upgrade or else major upgrade.

Old Releases: We should be supporting the older release, it doesn't make sense to force everyone to upgrade

HTTPlug: Do we want to give that much flexibility to users, debugging may be difficult. Your call, in my view, if we can restrict the user to a single library it is better.

from razorpay-php.

Aside: Requests 1.7 is now out: https://github.com/rmccue/Requests/releases

from razorpay-php.

@captn3m0 we have been using Request since the beginning ,and users also depend on it for updates as well. We will regularly add the updated Request.

Closing for now . will reopen if needed

from razorpay-php.