Comments (4)
If the performance impact is moderate, I would follow your advice from the Readme:
The general development philosophy is ease of use trumps performance, but performance is not to be ignored.
It sounds like a single code path would result in a considerable improvement in ease-of-use (both for end users and maintainers), larger than the reduction in performance.
Since Cherab already makes heavy use of caching and interpolating, perhaps some of the performance could be clawed back through improvements there, such as cherab/core#50.
from source.
I looked through the new code in v1/feature/polarisation. Even at this stage, it is already clear that maintaining both polarised and unpolarised versions of all related classes and methods would be very painful. I support the idea of abandoning the unpolarised light calculations, even at the cost of performance.
from source.
Thanks for the feedback. I have been heavily leaning to abandoning the unpolarised code. I've run a quick Cornell box test, it is looking to be a ~20% hit, but I think I can claw a lot of that back moving the internals from numpy to python.array.
from source.
Decision has been made that v1 will implement only polarised light propagation.
from source.
Related Issues (20)
- Allow Ray.extinction_min_depth to be equal to 1 HOT 2
- The 'quiet' argument passed to Observer1D and Observer2D at initialisation is ignored. HOT 1
- Proposal: material library update HOT 2
- SpectralPowerPipeline2D cannot be unpickled HOT 2
- Non-uniform step, absorption & scattering: inhomogeneous.pxd HOT 1
- Non-uniform step, absorption & scattering: inhomogeneous.pyx HOT 1
- Proposal: adaptive integration HOT 2
- Proposal: inhomogeneous absorption HOT 2
- Proposal: volumetric scattering HOT 1
- Update demos to support latest changes in Raysect and Matplotlib HOT 1
- Support parallel builds when installing with pip? HOT 4
- Publish manylinux wheel for Python 3.10 HOT 1
- Cython 3.0 compile error
- Cython 3.0 incompatible issue HOT 4
- conda installation failure HOT 11
- "Custom volume emitters" example broken HOT 2
- Missing inheriting arguments of observer base class HOT 9
- Help: Modelling diffuse reflectance from a known emitter and capture with camera
- Can't install raysect on mac HOT 1
- Limit numpy version to < 2 in install_requires and make another post release
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from source.