Comments (11)
ravibpatel
commented on June 14, 2024
@pinkfloydx33 Thanks for reporting it. You are right. If you want to open a pull request with the fix then please do it. I will merge it.
from ilrepack.lib.msbuild.task.
pinkfloydx33
commented on June 14, 2024
I'm ashamed to admit that I do not know how to use git. Otherwise I would be happy to make the fix.
from ilrepack.lib.msbuild.task.
ravibpatel
commented on June 14, 2024
@pinkfloydx33 I can do it but if you do it, it will make you a contributor in the repo. If you like to know how to use it, you can follow this tutorial from here. You just need to fork the repo to your account and then open it in Visual Studio change it and open pull request by logging into GitHub.
from ilrepack.lib.msbuild.task.
pinkfloydx33
commented on June 14, 2024
@ravibpatel Ok, I think I did it correctly. Originally I had just cloned the repository and then branched it but I wasn't sure if it was "proper" to commit my own branch into your repo. I ended up Forking like you suggested and I think I've done it right.
Once the PR is complete/merged, what do I do with the fork? Can I remove it? Or do I need to keep it around for all eternity? (Sorry, I know I sound like such a novice...)
from ilrepack.lib.msbuild.task.
pinkfloydx33
commented on June 14, 2024
@ravibpatel Actually -- the CI build has failed; Looks like an issue with the secret key. What did I do wrong?
from ilrepack.lib.msbuild.task.
ravibpatel
commented on June 14, 2024
@pinkfloydx33 There is nothing wrong on your part. Don't worry it only succeeds when I do the commit. I didn't fix it and yeah, I think you can remove fork after I merge it. I keep release name parallel with gluck/il-repack repo. Can you change it to 2.0.15.5?
from ilrepack.lib.msbuild.task.
pinkfloydx33
commented on June 14, 2024
Yeah sure. Do I have to create a whole new pull request or is it possible
for me to modify the existing one after I commit the changes into my fork?
I'll see if I can figure it out :)
…On Tue, Jun 26, 2018, 6:04 AM Ravi Patel ***@***.***> wrote:
@pinkfloydx33 <https://github.com/pinkfloydx33> There is nothing wrong on
your part. Don't worry it only succeeds when I do the commit. I didn't fix
it and yeah, I think you can remove fork after I merge it. I keep release
name parallel with gluck/il-repack
<https://github.com/gluck/il-repack/releases> repo. Can you change it to
2.0.15.5?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYJX2WfZ7AAo1lccFk3gqpvommqNJ5mks5uAgcygaJpZM4U2ECl>
.
from ilrepack.lib.msbuild.task.
ravibpatel
commented on June 14, 2024
I think you can commit it to your fork and it should be visible in the pull request.
from ilrepack.lib.msbuild.task.
pinkfloydx33
commented on June 14, 2024
Ok. Done!
from ilrepack.lib.msbuild.task.
ravibpatel
commented on June 14, 2024
@pinkfloydx33 Thanks. I merged it. I will tag it so it will be available on NuGet soon.
from ilrepack.lib.msbuild.task.
ravibpatel
commented on June 14, 2024
@pinkfloydx33 I pushed it to NuGet. Thanks again for the fix.
from ilrepack.lib.msbuild.task.
Related Issues (20)
- ILRepack is not working for desktop framework HOT 1
- Problem with duplicate Types HOT 7
- Could you please provide a new release? HOT 1
- CleanReferenceCopyLocalPaths Not Happening v2.0.18.1 HOT 9
- Release configuration merge gives error failed to resolve assembly HOT 11
- did ILRepack surport vs2019 + .net framework 4.7.2? HOT 6
- dotnet build not working HOT 5
- PrimaryAssemblyFile only added on Release Builds
- Failed to resolve assembly Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' HOT 3
- Where do we put the reference to the key HOT 4
- Build task isn't re-signing/strong-naming my assembly HOT 2
- InvalidCastException when trying to merge Oracle.ManagedDataAccess.dll HOT 1
- Support regex in InternalizeExclude HOT 1
- Force exclude a library reference from being merged in HOT 2
- Internalize not working with 2.0.22 HOT 13
- Nuget API key in appveyor.yml file? HOT 1
- Should the NuGet package be marked as a development dependency? HOT 4
- Repacking Harmony in Debug mode fails HOT 8
- Update to ILRepack 2.0.31 HOT 1
- “lc.exe”Exited，4.6--4.8.net framework ，Can we add a project Sample for learning purposes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ilrepack.lib.msbuild.task.