Giter Club home page Giter Club logo

Comments (1)

silkentrance avatar silkentrance commented on August 24, 2024 1

Thank you for pointing this out.

We had a few bug fixes erroneously labelled as breaking changes.

- (Breaking Change) SIGINT handler has been removed.

was replaced by

* (Bug Fix) [#193](https://github.com/raszi/node-tmp/pull/193) Closes [#192](https://github.com/raszi/node-tmp/issues/192): tmp must not exit the process on its own ([@silkentrance](https://github.com/silkentrance))

and similar such cases.

But we also lost some information in the process of switching to lerna-changelog, namely the information that was entered manually and for which no PR exists, e.g.

-  node versions < v8.17.0 are no longer supported. 

and similar such information.

However, we broke the system somewhat when forcing all paths to be relative to the configured tmpdir.

-  template option no longer accepts arbitrary paths. all paths must be relative to os.tmpdir().
-  the template option can point to an absolute path that is located under os.tmpdir().
-  this can now be used in conjunction with the dir option. 
...
-  dir option no longer accepts arbitrary paths. all paths must be relative to os.tmpdir().
-  the dir option can point to an absolute path that is located under os.tmpdir().
...
-  name option no longer accepts arbitrary paths.
-  name must no longer contain a path and will always be made relative to the current os.tmpdir() and the optional dir option.
...
-  fail early if no os.tmpdir() was specified.
-  previous versions of Electron did return undefined when calling os.tmpdir().
-  _getTmpDir() now tries to resolve the path returned by os.tmpdir().
-  now using rimraf for removing directory trees.

These changes are now labelled as either bug fixes or enhancements or internal.

The need for all paths to be relative to the configured tmpdir along with also limitations on the tmp names and paths did raise some issues and we are trying to address that with the future typescript rewrite.

And, we must make sure that we have a PR for every change we make so that it gets labelled correctly and will show up in the automatically generated changelog.

from node-tmp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.