Giter Club home page Giter Club logo

Comments (1)

Raruto avatar Raruto commented on May 27, 2024

Hi @mttucl,

If you're interested in seeing it resolved, please check it out and pitch a PR.

I would say that the problem is related to yMax calculation (I haven't checked in detail):

image

leaflet-elevation/src/components/marker.js

Line 55 in bd9316b

let yMax = (this.control._height() / props.yCoordMax * point[this.options.yAttr]);

leaflet-elevation/src/components/marker.js

Lines 63 to 64 in bd9316b

yCoord: point.y,
length: point.y - yMax, // normalized Y

leaflet-elevation/src/components/d3.js

Lines 129 to 134 in bd9316b

line
.attr("class", theme + " height-focus line")
.attr("x1", xCoord)
.attr("x2", xCoord)
.attr("y1", yCoord)
.attr("y2", length);

which also depends on yCoordMax variable:

leaflet-elevation/src/control.js

Line 189 in bd9316b

this._yCoordMax = -Infinity;

leaflet-elevation/src/control.js

Line 365 in bd9316b

if (this._yCoordMax < this._data[this._data.length - 1][this.options.yAttr]) this._yCoordMax = this._data[this._data.length - 1][this.options.yAttr];

leaflet-elevation/src/control.js

Lines 1257 to 1269 in bd9316b

/*
* Update the position/height indicator marker drawn onto the map
*/
_updateMarker(item) {
if (this._marker) {
this._marker.update({
map : this._map,
item : item,
yCoordMax : this._yCoordMax || 0,
options : this.options
});
}
},

If you're interested in seeing it resolved, please take a hard look and pitch a PR.

👋 Raruto

from leaflet-elevation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.