Properly declare and import type definitions about rapid.js HOT 13 OPEN

@drewjbartlett, @yihou I would start fixing these errors

from rapid.js.

https://github.com/mgred/rapid.js/tree/rapid.js-41

from rapid.js.

I refactored so far to get rid of the typings directory.

from rapid.js.

@mgred you are the man thank you! Sorry for the delay. Just got back from a trip. Will have a look at this asap!

from rapid.js.

@mgred I know it has been forever since I have followed up with this -- finally had a moment to dive in here and honestly I am just a little lost on how I can get my tests to start passing. Do you have any thoughts?

from rapid.js.

@mgred That is the test file, that is the output. As soon as I add the line for Core, it stops working. This is what is holding me up from finishing this :(

from rapid.js.

@drewjbartlett I'm on a trip currently and will have look this evening.

from rapid.js.

@mgred no worrries/rush at all :D

from rapid.js.

@drewjbartlett I switched to my branch rapidjs-41 where I made some refactorings. The test passes more or less but the promise seems not be handled correctly.

I still don't know why it's not working on our main refactoring branch v2-refactor, but I will investigate. Maybe It's just some setting in the tsconfig.json which also used by Jest.

from rapid.js.

ah that would make sense! That's good news you can get it working partially! I really appreciate all the help @mgred

from rapid.js.

@mgred I have been thinking a bit and I need to be able to easily test this. TS is not allowing me to do this easily. If I can't get this figured out soon the reality is that v2 will not happen. I am feeling a little discouraged at committing fully to TS before fully understanding it and getting a solid workflow in place.

I appreciate all the work everyone is putting in but I just can't get caught up in the build tools, etc. Lemme know if you have any suggestions :)

from rapid.js.

@drewjbartlett I still try to figure out why the tests are not running on the main refactoring branch, I updated the tsconfig.json to be like the one on my branch rapid.js-41

{
"module" : "commonjs",
"noEmit": false
}

but still it shows the same error. I will give you the MR for this issue/branch. You can then continue with a working build and test environment as far as I can say

from rapid.js.

#45

from rapid.js.