Giter Club home page Giter Club logo

Comments (3)

SethDavenport avatar SethDavenport commented on July 30, 2024

Here's the code in question:

'use strict';
'format es6'; // force SystemJS to transpile exercise

const LIMIT = 5;

function isOverLimit(val) {
  let result;
  if (val > LIMIT) {
    result = true;
  } else {
    result = false;
  }
  return result;
}

const element = document.getElementById('example');
element.innerHTML = isOverLimit(10);

from ngcourse2.

SethDavenport avatar SethDavenport commented on July 30, 2024

Looks like it should work. However looking at the SystemJS transpiled output reveals the problem:

(function(System) {(function(__moduleName){System.register([], function(exports_1) {
    'use strict';
    'format es6'; // force SystemJS to transpile exercise
    var LIMIT, element;
    function isOverLimit(val) {
        var result;
        if (val > LIMIT) {
            result = true;
        }
        else {
            result = false;
        }
        return result;
    }
    return {
        setters:[],
        execute: function() {
            var LIMIT = 5;
            var element = document.getElementById('example');
            element.innerHTML = isOverLimit(10);
        }
    }
});

In effect, the LIMIT variable is getting shadowed when it's value is assigned in the execute block.

from ngcourse2.

SethDavenport avatar SethDavenport commented on July 30, 2024

While not central to the exercise, it would be nice not to have SystemJS confuse the issue. Quick fixes include:

  1. Wrapping the whole file in an IIFE
  2. Making LIMIT a member of window
  3. Making LIMIT a local constant in isOverLimit.

(3) is probably cleanest - @bennett000 - thoughts?

from ngcourse2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.