Comments (3)
Here's the code in question:
'use strict';
'format es6'; // force SystemJS to transpile exercise
const LIMIT = 5;
function isOverLimit(val) {
let result;
if (val > LIMIT) {
result = true;
} else {
result = false;
}
return result;
}
const element = document.getElementById('example');
element.innerHTML = isOverLimit(10);
from ngcourse2.
Looks like it should work. However looking at the SystemJS transpiled output reveals the problem:
(function(System) {(function(__moduleName){System.register([], function(exports_1) {
'use strict';
'format es6'; // force SystemJS to transpile exercise
var LIMIT, element;
function isOverLimit(val) {
var result;
if (val > LIMIT) {
result = true;
}
else {
result = false;
}
return result;
}
return {
setters:[],
execute: function() {
var LIMIT = 5;
var element = document.getElementById('example');
element.innerHTML = isOverLimit(10);
}
}
});
In effect, the LIMIT variable is getting shadowed when it's value is assigned in the execute
block.
from ngcourse2.
While not central to the exercise, it would be nice not to have SystemJS confuse the issue. Quick fixes include:
- Wrapping the whole file in an IIFE
- Making
LIMIT
a member ofwindow
- Making
LIMIT
a local constant inisOverLimit
.
(3) is probably cleanest - @bennett000 - thoughts?
from ngcourse2.
Related Issues (20)
- Update - ECMAScript 6 and Typescript
- Update - Javascript Toolchain
- Update - Bootstrapping an Angular Application
- Update - Components in Angular
- Update - Directives
- Update - Advanced Components
- Update - Observables
- Update - Angular Dependency Injection HOT 1
- Update - Http
- Update - Change Detection
- Update - Zone.js
- Update - Advanced Angular
- Update - Immutable.js
- Update - Pipes
- Update - Forms HOT 1
- Update - Modules
- Update - Routing
- Update - State Management
- Update - TDD Testing
- Update Routing Examples
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngcourse2.