Comments (8)
I'm not eager to change how we calculate dHv for this paper. What they propose may be better, but as you mentioned, it's inconsistent with how we calculated dHv in the past, and it's going to throw off the validation of MBAR and confuse people.
I agree.
The paper is not about system size effects (we are writing another paper on that, btw), and the data show reasonably small system size effects except in the near critical region, anyway.
To satisfy this reviewer we can also mention the finite-size effects investigation we performed for cyclohexane.
Using this other method is not going to produce substantially different results, nor would it change the optimal parameters, since the scoring function is designed to focus primarily on liquid density and vapor pressure.
For example, we still got essentially the same optimal as the TAMie force field that was optimized using the alternative method.
That said, we could try it on the cyclohexane data and see what we get. Not opposed to using this method in the future, but I think it's not a good idea to change it for this paper.
I think we leave this approach to future studies if we find it to be necessary.
from jced_fomms_manuscript.
@ramess101 I'm not eager to change how we calculate dHv for this paper. What they propose may be better, but as you mentioned, it's inconsistent with how we calculated dHv in the past, and it's going to throw off the validation of MBAR and confuse people. The paper is not about system size effects (we are writing another paper on that, btw), and the data show reasonably small system size effects except in the near critical region, anyway. Using this other method is not going to produce substantially different results, nor would it change the optimal parameters, since the scoring function is designed to focus primarily on liquid density and vapor pressure.
That said, we could try it on the cyclohexane data and see what we get. Not opposed to using this method in the future, but I think it's not a good idea to change it for this paper.
from jced_fomms_manuscript.
My response:
from jced_fomms_manuscript.
@ramess101 @jpotoff
Here are the results for calculating the dHV using GCMC + HR (dHv, blue), Weidler and Gross (dHv2, red), and GEMC (green). There are good agreements in high temperature for all 3 methods, but at low temperature, Weidler and Gross deviates by ~0.6 kcal/mol. I attached the results for you.
out_average_GEMC.txt
out_butane_40A.txt
from jced_fomms_manuscript.
Very interesting. This seems to suggest that our approach is actually better than Weidler and Gross against finite-size effects at low T. I guess, is it possible GEMC has finite-size effects for such low densities in the vapor phase at low T?
from jced_fomms_manuscript.
@ramess101 I have around 160 molecule in my gas phase. Usually GEMC shows finite size effect near critical points. Have you tried to apply the Weidler and Gross for cyclohexane results?
from jced_fomms_manuscript.
Yeah, I have never seen traditional finite-size effects in GEMC at low T. But if N = 0 in the vapor phase it could be a similar problem to GCMC with poor averaging. This could also come back to the discussion we had previously about / vs <N/V> and / vs /. Where this distinction doesn't impact the Weidler and Gross analysis.
I haven't applied their approach.
from jced_fomms_manuscript.
Just following up on this because we have some new data. If one calculates the d ln p/d (1/T) at each temperature of interest, no significant difference is observed between the two methods.
from jced_fomms_manuscript.
Related Issues (20)
- Hardware description HOT 5
- Manuscript ready for further review
- Equation 8 and 9 HOT 3
- Physical explanation of Keff in vapor and liquid phases HOT 4
- Reviewer 1 Comment 4 HOT 22
- Reviewer 1 Comment 5 HOT 14
- Reviewer 1 Comment 6 HOT 5
- Reviewer 1 Comment 7 HOT 5
- Reviewer 2 Comment 1 HOT 100
- Reviewer 2 Comment 3 HOT 5
- Reviewer 2 Comment 6 HOT 12
- Reviewer 3 Comment 1 HOT 3
- Reviewer 3 Comment 2 HOT 3
- Reviewer 3 Comment 3 HOT 9
- Reviewer 1 Comment 1
- Reviewer 1 Comment #2 HOT 1
- Reviewer 1 Comment 3
- Reviewer 2 Comment 2
- Reviewer 2 Comment 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jced_fomms_manuscript.