Giter Club home page Giter Club logo

Comments (10)

RalfG avatar RalfG commented on June 29, 2024 1

Thanks for the PR, @mr-c! (#62)

from python-wheels-manylinux-build.

RalfG avatar RalfG commented on June 29, 2024 1

Apologies, I did not realize that findutils was required by the action itself. v0.7.1 now installs findutils by default and additionally fixes a bug where the use of sh instead of bash resulted in issues on musllinux containers.

from python-wheels-manylinux-build.

mr-c avatar mr-c commented on June 29, 2024

As a workaround, trying system-packages: findutils gives

 + command -v apt-get
+ command -v yum
+ echo 'Package managers apt or yum not found.'`

Would be nice if apk was added to the list..

from python-wheels-manylinux-build.

mr-c avatar mr-c commented on June 29, 2024

Thanks @RalfG ; can you automatically add a system-packages: findutils or equivalent for musllinux_1_1_x86_64 users? It will save them some headache :-)

from python-wheels-manylinux-build.

mr-c avatar mr-c commented on June 29, 2024

Thank you @RalfG !

from python-wheels-manylinux-build.

mr-c avatar mr-c commented on June 29, 2024

If you have any advice for what failed my build with 0.7.1 ; it would be welcome

https://github.com/common-workflow-language/schema_salad/actions/runs/3999677201/jobs/6863864899#step:9:614

https://github.com/common-workflow-language/schema_salad/actions/runs/3999677201/jobs/6863864899#step:10:529

Did a file get copied to the wrong directory?

from python-wheels-manylinux-build.

RalfG avatar RalfG commented on June 29, 2024

I think the issue is that after the first build, the consecutive builds reuse some of the previously compiled files. Maybe there is a way to force pip wheel to do a full rebuild, or you can manually remove those files between builds for the different platforms (e.g., the build dir).

from python-wheels-manylinux-build.

mr-c avatar mr-c commented on June 29, 2024

@RalfG Hmm.. there is no post-build-command option and outside the container one lacks permissions to move files outside of dist: https://github.com/common-workflow-language/schema_salad/actions/runs/4024224052/jobs/6916008349

I'll see what I can do with setting pip-wheel-args to something likle -w ./dist_musllinux --no-deps (but obviously that is fragile)

(Thanks again for this GitHub Action and your help!)

from python-wheels-manylinux-build.

mr-c avatar mr-c commented on June 29, 2024

Hmm.. the wheels (and fixed-up wheels) got written to ./dist_musllinux,

https://github.com/common-workflow-language/schema_salad/actions/runs/4024396814/jobs/6916379545#step:9:612

but later there are still problems with RalfG/[email protected]_x86_64

https://github.com/common-workflow-language/schema_salad/actions/runs/4024396814/jobs/6916379545#step:10:569

I'll try re-ordering the builds next. The last thing I can think of is a matrix build and uploading separately

from python-wheels-manylinux-build.

mr-c avatar mr-c commented on June 29, 2024

So I fixed this by completely splitting the config up into separate jobs. Alas, since the action name field (uses) is not allowed to be parameterized by a GitHub Action Expression, one can't use a Matrix to iterate this way.

https://github.com/common-workflow-language/schema_salad/blob/13395631183f7788c7a3a143051d8b3f298b09eb/.github/workflows/wheels.yml

Thanks again for your help!

from python-wheels-manylinux-build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.