Comments (6)
Hi Sergei,
I think this is a good idea. There's a trick used here that should get PR previews working. GitHub Pages doesn't directly support PR previews, but that approach should work.
I'm uncertain when I'll have a moment to look into this idea, but I support the feature and I'm open to pull requests if anyone wants to figure it out.
Thanks for reaching out!
-Robert
from marp-to-pages.
Hi @ralexander-phi, thanks for the follow-up and reference, I've found a way to upload previews and I will submit a PR for that in some time.
from marp-to-pages.
For the solution, see .github/workflows/build-preview.yml at spetrosi/jak_psat_moderni_ucebnice#4
from marp-to-pages.
Hi Sergei,
I stumbled into the rossjrw/pr-preview-action repo recently. I've been wary of putting too much non-marp related code into marp-action, so I've been slow to act on this issue. However, the pr-preview-action can handle those tasks instead. I wanted to get your thoughts as you've looked into the preview problem already.
Here's a demo of building marp (using the marp-cli Docker container this tiime) and deploying with other actions:
from marp-to-pages.
Hi Rob, I am coll with it if it works. Your PR at ralexander-phi/improved-marp-pages-example#3 must have proven that it works and I am glad that this improvement made it into marp-action. Thank you :) I guess you can close this issue now.
from marp-to-pages.
I'll run some cleanup on this, but #7 should complete this request. Thanks for taking a look Sergei!
from marp-to-pages.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marp-to-pages.