errors when loading Thorfiles do not include stacktrace about thor HOT 6 CLOSED

Fixed in in my fork at technicalpickles/thor@f85c87b. I ended up just doing a puts of the error's backtrace.

from thor.

I think it's probably acceptable, but I'm hesitant to change it. If I were fixing it myself I'd probably either show the top line of the stack trace or print the whole thing out to a log file.

from thor.

The top line of the backtrace wouldn't be sufficient in a lot of cases, I think. It's only useful if the error comes from a line in the Thorfile.

Logging it would be better, but I think it's a little overkill. If you're working on a thorfile in the current directory, and you are trying to call tasks defined in it, I really want to see backtraces that happened, and not have to know that there's an error log somewhere, and then actually open the file.

from thor.

Fwiw, I believe this was added to prevent misbehaving global Thor helpers from always bombing Thor out. Do you guys have any thoughts on making that case usable/not horrible?

from thor.

Yeah, it was added to prevent thor from exploding due to some bad files. Showing the whole backtrace would be cumbersome, +1 for showing just the first line. You can invoke thor path/to/faulty/Thorfile --debug to get the whole error (at least I hope so).

from thor.

I did what josevalim suggested. Find the commit here.

from thor.