Giter Club home page Giter Club logo

Comments (8)

jon-sully avatar jon-sully commented on June 29, 2024 1

FWIW I've set my Webpack config as

const mode = (process.env.RAILS_ENV === "production" ? "production" : "development")

module.exports = {
  mode,
  ...
  // etc

Since Rails has at least one environment (typically) that webpack doesn't support (test)

from jsbundling-rails.

jon-sully avatar jon-sully commented on June 29, 2024 1

I opened this over a year ago and we don't even use Webpack anymore so 😆 no biggie from me!

from jsbundling-rails.

Faq avatar Faq commented on June 29, 2024

That introduced with 922b030 by @bholtbholt

from jsbundling-rails.

bholtbholt avatar bholtbholt commented on June 29, 2024

@jon-sully its possible it could/should be RAILS_ENV. In the app I did the conversion on we had NODE_ENV set so it was changing between builds.

It's been about over a year since I did the conversion and wrote the guide, so it's also possible Heroku, Rails, and Webpack changes have affected it. If it's out of date then it's definitely worth updating.

The important piece to keep in mind is that with mode: "development" webpack compiles and watches in a different way, using local caches, which makes the build faster.

from jsbundling-rails.

bholtbholt avatar bholtbholt commented on June 29, 2024

I wonder why i got tagged today 🤷‍♂️

from jsbundling-rails.

jon-sully avatar jon-sully commented on June 29, 2024

@Faq commented 8 hours ago but prior comment was a year ago 😅 Alas.

from jsbundling-rails.

Faq avatar Faq commented on June 29, 2024

Thank you for the answer.

from jsbundling-rails.

dhh avatar dhh commented on June 29, 2024

Feel free to update docs in a PR if anything is still out of date.

from jsbundling-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.