Giter Club home page Giter Club logo

Comments (4)

vitchyr avatar vitchyr commented on June 20, 2024

Good point. Hmmm, I'm not sure if I want to remove the dependence on MultitaskEnv since that defines the interface. The env_util functions could also be copy/pasted from multiworld, though it seems like a bit redundant.

If you don't want to install multiworld, you can copy/paste the code from here, but otherwise I'm open to suggestions for how else you might fix this.

from rlkit.

dwiel avatar dwiel commented on June 20, 2024

from rlkit.

CarloLucibello avatar CarloLucibello commented on June 20, 2024

multiworld is needed to run the DQN example on CartPole as well, which is not ideal:

$ python examples/dqn_and_double_dqn.py 
Traceback (most recent call last):
  File "examples/dqn_and_double_dqn.py", line 12, in <module>
    from rlkit.torch.dqn.dqn import DQNTrainer
  File "/home/carlo/Git/rlkit/rlkit/torch/dqn/dqn.py", line 10, in <module>
    from rlkit.torch.torch_rl_algorithm import TorchTrainer
  File "/home/carlo/Git/rlkit/rlkit/torch/torch_rl_algorithm.py", line 7, in <module>
    from rlkit.core.batch_rl_algorithm import BatchRLAlgorithm
  File "/home/carlo/Git/rlkit/rlkit/core/batch_rl_algorithm.py", line 4, in <module>
    from rlkit.core.rl_algorithm import BaseRLAlgorithm
  File "/home/carlo/Git/rlkit/rlkit/core/rl_algorithm.py", line 8, in <module>
    from rlkit.samplers.data_collector import DataCollector
  File "/home/carlo/Git/rlkit/rlkit/samplers/data_collector/__init__.py", line 6, in <module>
    from rlkit.samplers.data_collector.path_collector import (
  File "/home/carlo/Git/rlkit/rlkit/samplers/data_collector/path_collector.py", line 3, in <module>
    from rlkit.envs.vae_wrapper import VAEWrappedEnv
  File "/home/carlo/Git/rlkit/rlkit/envs/vae_wrapper.py", line 11, in <module>
    from multiworld.core.multitask_env import MultitaskEnv
ModuleNotFoundError: No module named 'multiworld'

from rlkit.

vitchyr avatar vitchyr commented on June 20, 2024

Addressed with 60d1ab8. Thanks for the feedback!

from rlkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.