Giter Club home page Giter Club logo

Comments (1)

davebaol avatar davebaol commented on July 20, 2024

Yes, there are a few places where quotes are missing:

  • confFileOpts += " -c " + configFile

    it should be
      confFileOpts += ` -c "${configFile}"`
  • puppeteerOpts += " -p " + puppeteerConfig

    it should be
      puppeteerOpts += ` -p "${puppeteerConfig}"`
  • confFileOpts += " -C " + cssFile

    it should be
      confFileOpts += ` -C "${cssFile}"`
  • var fullCmd = `${cmd} ${confFileOpts} ${puppeteerOpts} -w ${options.width} -f -i ${tmpfileObj.name} -t ${options.theme} -o ${savePath}`

    it should be (note that cmd value is already quoted, but temp and output files are not)
      var fullCmd = `${cmd}  ${confFileOpts} ${puppeteerOpts} -w ${options.width} -f -i "${tmpfileObj.name}" -t ${options.theme} -o "${savePath}"`

@raghur
It would be great if you could fix them and publish a new version on npm 🥰

from mermaid-filter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.