Comments (7)
Hi, thanks for the issue
Yeah, I should be uploading a patch by tomorrow after analyzing this problem more precisely.
from vulkan.
I was unable to reproduce this error locally, could you please show me a screenshot of the error and send me the exact playlist you are having problems with?
from vulkan.
Hi, sorry for the delay in getting back to you, I did some further testing and it seems that eventually most of the time (Not all of the time) the bot does actually start playing the songs it just takes a long time (Probably depending on the size of the playlist) when it does eventually start playing the buttons (Play, Stop, Skip etc) don't seem to respond and it throws an error.
I attached some screenshots of the console spam as well as the error for the buttons. I wasn't able to get a screenshot of it but it also appears that the bot reloads/restarts a few times during the console spam (It shows the "Starting Vulkan" message multiple times in the middle of the spam)
Here's an example playlist that has caused it to crash/take a significant amount of time to start playing: https://open.spotify.com/playlist/15sZyUgStYmvzm3QfdVDIp?si=c27c0359c5064dd5
I also attached a screenshot of a message relating to a cache file which I'm not sure is related?
from vulkan.
Yes, I found this delay to play the songs when the input is a large playlist
I kinda solved this problem in this commit
When the playlist contains more than 10 songs, the Bot will prioritize the download and start playing the first 5 songs instead of downloading all the songs in the playlist.
About the buttons, they are not the best thing implemented by the pycord library, as they have a lifetime, after some time they cannot be used anymore, I tried to avoid this problem by disabling the buttons before the end of their lifetime (What is a behavior that I can't change), but that doesn't work every time, if you find any pattern to throw this error I would like to know that.
About the cache, it is not implemented by this project, maybe it is from the library responsible for downloading songs from Youtube, yt-dlp, this library usually launches some random prints on the console.
The Starting Vulkan
message shows up when a Process is created to play the song in one channel or when some error occured and the process is restarted, skipping to the next song.
Try to git pull the latest version of Vulkan and see if the delay to starting playing the songs is fixed.
from vulkan.
Hi, I just tested the bot and I think you have "fixed" the problem with the delay in playing the songs, however "I think" not 100% I think if you disconnect the bot using either the stop button or a command to disconnect the bot from VC and then try playing another playlist or even the same playlist the bot has to finish downloading the songs from the previously requested playlist before it can start downloading the newly requested one.... If that makes sense?
from vulkan.
Yes, this is the current behavior, the bot contains a main process that listens to all commands received by Discord and a process for each guild to play the songs, so there is no chance that downloading too many songs will degrade the quality of the music playing.
However, the main process, also responsible for downloading the songs, cannot perform these operations instantly, there is a delay to download the songs and the Stop command currently does not cancel all the threads triggered to download the songs, there is no control for that.
I fixed an issue I ran into when you would stop and play again like you said, but it doesn't change the current behavior of the Bot.
from vulkan.
I'm closing the issue as completed, any question don't mind opening other issue, thanks for your time and effort
from vulkan.
Related Issues (20)
- ValueError: mutable default <class 'discord.utils._MissingSentinel'> for field name is not allowed: use default_factory HOT 1
- Bug queue HOT 5
- Help command error HOT 1
- No audio/sound after voice channel connection HOT 5
- Bot Not Working Anymore HOT 1
- Add Volume Feature HOT 1
- Bug HOT 6
- Bot fails to play certain Youtube videos HOT 2
- Bot does not like mobile Youtube links (m.youtube.com) HOT 1
- Bug
- Add autoplay? HOT 3
- [Enhancement]: Docker comtainerization HOT 2
- Bug HOT 2
- Bot goes to "sleeping" state immediately after starting playback HOT 3
- Bug HOT 1
- Googlevideo returning 403 forbiddenBug HOT 4
- Bug ImportError: cannot import name 'SlashCommandOptionType' from 'discord.enums' HOT 4
- Bot searches for YT Song instead of actually playing the one on Spotify. HOT 2
- bot not showing music commands HOT 2
- When I try to queue a Spotify playlist it doesn't work... HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vulkan.