Comments (2)
Thanks for all your great contributions to the web community.
I noticed your comment here. But I find it unclear. I was hoping you could clear up your comment above.
"really well done script here...": does that refer to css_browser_selector or cssuseragent?
"has some fixes that arent part of this one.": same question, which script is this referring to?
Are you saying that cssuseragent is the better script or css_browser_selector? and why? and if cssuseragent, what features do you think it has that css_user_agent does not?
I find css_browser_selector.js to be an excellent script. For me, css_browser_selector, goes into the right amount of detail. The script if small and easy to understand. Cssuseragent user agent also appears to be a good script, but, in my opinion, it seems to go into too much detail, and is not as easy to understand. It also left off your suggestion about either adding "js" or replacing "no-js" with "js".
I recently made some revisions to css_browser_selector to include several of the suggestions that were left in the pull requests, including yours about "js".(you'll see a 'hat tip' to you at the bottom of the script)
My version now includes:
any version of Firefox
more versions of Windows (Win7, Vista, XP, Win2k)
more versions of IE under unique conditions
if "no-js" present in HTML, replaces with js
https://github.com/verbatim/css_browser_selector
I'd love your feedback, if you feel I have improved this script.
from css_browser_selector.
Hey verbatim..
I was referring to cssuseragent in both cases.
His javascript is really well written (and you can read it). He also has a test suite which i'd love to see in this project.
OOOh your fork looks great. thanks for the formatting. :)
you should combine the lines 71 and 72, so you only set the className just one.
otherwise it's ace.
(just could use a test suite)
from css_browser_selector.
Related Issues (20)
- please support flash and flash version!
- please support ie10 HOT 6
- maintained? HOT 4
- Chrome vs Safari on iOS
- IE11 not working HOT 11
- Problems with Android browser detection
- Android Tablet, Chrome browser detection HOT 2
- iPad 2 browsers and iOS not being detected properly
- Samsung galaxy tab2 7.0 Chrome current
- New UA string for Windows 8.1 HOT 1
- Chrome for android HOT 2
- Hi using IE 11.0.9 and its showing Red (win 7 64bit) HOT 11
- Problem in Nokia Lumia 730 phone
- Updated for Win 8.1 / IE 8, 9, 10, 11
- Add GPLv2 or MIT Licence
- Support Yandex Browser
- adding tags for the repo
- Add selector for Edge browser HOT 2
- BrowserInfo 2016-11
- Opera 58.0.3135.68 is wrong . HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from css_browser_selector.