Comments (11)
I'm curious why not Vue emits? why we recreate the emits again?
at least for events on components we can use Vue emits but for document or window scope we need CustomEvent
@sadeghbarati I think using Custom Event here make sense, as we can target the specifc node with the event, and user can listen to that event by using v-on
from Vue. v-on:enter
or @enter
.
Yeah we should add isClient
in this function as it make sense to have this animation custom event to be triggered only in client-side.
from radix-vue.
https://stackblitz.com/edit/github-uewhkz
node v18 and pnpm working right ✅
The problem might be localized to certain components; I forked your repo and used a Toast instead and was able to reproduce the error
https://stackblitz.com/edit/github-uewhkz-cd6pvt
from radix-vue.
Same problem :/
from radix-vue.
Seems to be happening using PNPM and Node18, no issue using Yarn and Node20
from radix-vue.
Yup might be Node18 doesn't support
CustomEvent
nodejs/node#40678. @luigigorlero @roberthgnz can you try bump the Node version and see if it works? 😁
Can confirm same setup Nodev18 throws a fatal, Nodev20 works flawlessly!
from radix-vue.
Yup might be Node18 doesn't support CustomEvent
nodejs/node#40678.
@luigigorlero @roberthgnz can you try bump the Node version and see if it works? 😁
from radix-vue.
I am using the library with Nuxt, I have solved it by loading the route in SPA mode, in that case I don't need it to be SSR.
from radix-vue.
So what now? What about the apps running on node18?
from radix-vue.
I'm curious why not Vue emits? why we recreate the emits again?
at least for events on components we can use Vue emits but for document or window scope we need CustomEvent
Perhaps using isClient
before using CustomEvents might help solving this issue
from radix-vue.
Could someone prepare a minimal reproduction which fails on Node 18?
from radix-vue.
https://stackblitz.com/edit/github-uewhkz
node v18 and pnpm working right ✅
from radix-vue.
Related Issues (20)
- [Bug]: checkbox does not dispatch "input" event, like native checkbox HOT 2
- [Bug]: use `aria-hidden="true"`, not `aria-hidden=""` HOT 2
- [Bug]: `data-disabled` attribute is missing on `NumberFieldRoot` element
- [Chore]: Replace the deprecated `eslint` configuration
- [Bug]: Tooltip appearance issues with touch-devices HOT 3
- [Bug]: Opening `Popover` with empty `Listbox` causes TypeError: Cannot read properties of undefined (reading 'focus')
- [Bug]: opening Combobox causing error
- [Feature]: Add Tree Triger componet to expand the the node
- [Feature]: Allow selection when pressing Tab in Select
- [Bug]: style-src Content Security Policy Enforcement HOT 2
- [Bug/v2]: ComboboxItem unhandled error in mounted HOT 5
- [Feature]: Add clear-value functionality to the Select Component HOT 3
- [Feature]: nuxt-layer ts compatible HOT 4
- [Feature]: TimeField Component HOT 2
- [Bug]: Pin Input crashes on Chrome 91 HOT 1
- [Feature]: Access more fine grained control in DateField Component
- [Bug]: Crash with Teleport when not using v-model on Toast
- [Bug]: Toast breaks SSR on Vercel
- [Bug]: `SelectItemText` possible vulnerability
- [Bug]: `v-if` text is included in TooltipContent computed aria-label HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from radix-vue.