Giter Club home page Giter Club logo

Comments (11)

zernonia avatar zernonia commented on September 27, 2024 3

I'm curious why not Vue emits? why we recreate the emits again?
at least for events on components we can use Vue emits but for document or window scope we need CustomEvent

@sadeghbarati I think using Custom Event here make sense, as we can target the specifc node with the event, and user can listen to that event by using v-on from Vue. v-on:enter or @enter.

Yeah we should add isClient in this function as it make sense to have this animation custom event to be triggered only in client-side.

from radix-vue.

luigigorlero avatar luigigorlero commented on September 27, 2024 3

https://stackblitz.com/edit/github-uewhkz

node v18 and pnpm working right ✅

The problem might be localized to certain components; I forked your repo and used a Toast instead and was able to reproduce the error
https://stackblitz.com/edit/github-uewhkz-cd6pvt

from radix-vue.

roberthgnz avatar roberthgnz commented on September 27, 2024 1

Same problem :/

from radix-vue.

luigigorlero avatar luigigorlero commented on September 27, 2024 1

Seems to be happening using PNPM and Node18, no issue using Yarn and Node20

from radix-vue.

luigigorlero avatar luigigorlero commented on September 27, 2024 1

Yup might be Node18 doesn't support CustomEvent nodejs/node#40678. @luigigorlero @roberthgnz can you try bump the Node version and see if it works? 😁

Can confirm same setup Nodev18 throws a fatal, Nodev20 works flawlessly!

from radix-vue.

zernonia avatar zernonia commented on September 27, 2024

Yup might be Node18 doesn't support CustomEvent nodejs/node#40678.
@luigigorlero @roberthgnz can you try bump the Node version and see if it works? 😁

from radix-vue.

roberthgnz avatar roberthgnz commented on September 27, 2024

I am using the library with Nuxt, I have solved it by loading the route in SPA mode, in that case I don't need it to be SSR.

from radix-vue.

BayBreezy avatar BayBreezy commented on September 27, 2024

So what now? What about the apps running on node18?

from radix-vue.

sadeghbarati avatar sadeghbarati commented on September 27, 2024

I'm curious why not Vue emits? why we recreate the emits again?
at least for events on components we can use Vue emits but for document or window scope we need CustomEvent

Perhaps using isClient before using CustomEvents might help solving this issue

from radix-vue.

DamianGlowala avatar DamianGlowala commented on September 27, 2024

Could someone prepare a minimal reproduction which fails on Node 18?

from radix-vue.

sadeghbarati avatar sadeghbarati commented on September 27, 2024

https://stackblitz.com/edit/github-uewhkz

node v18 and pnpm working right ✅

from radix-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.