Giter Club home page Giter Club logo

Comments (17)

radityaharya avatar radityaharya commented on July 20, 2024 1
  • Add Movie Calendar as a separate iCalendar

I'm planning to do this eventually

  • Add the Streaming Platform in the location

Example
Screenshot_20230713-204131_Calendar

Yes!, I wanted to include this as well. But as far as I know Trakt's API doesn't provide streaming platform info but it does include ids to tmdb and tvdb. I'll try to hook it up

  • improve The Event Time by using the Episode/Movie Runtime

Example
Screenshot_20230713-204403_Calendar

I've implemented it on the latest commit. Should be up and working

from trakt_ical.

radityaharya avatar radityaharya commented on July 20, 2024 1

Add Movie Calendar as a separate iCalendar

Add a dash between the tv name and the Season Episode Number to separate them easily

Added both on the latest commit, give it a go :D

from trakt_ical.

radityaharya avatar radityaharya commented on July 20, 2024 1

I do have a suggestion though, for the movie you could add the year in a parenthesis like so

Added!

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

Great, thanks for the consideration ^⁠_⁠^

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

And also one little change:
Add a dash between the tv name and the Season Episode Number to separate them easily

Example
Screenshot_20230714-084301_Calendar

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

Sorry for late reply, I checked and it works very well ^⁠_⁠^
Screenshot_20230718-160937_Calendar
I do have a suggestion though, for the movie you could add the year in a parenthesis like so
Screenshot_20230718-160711_Calendar

Thanks for your efforts i really appreciate it, and i think this project is fantastic and definitely more users will use it once they find it ;) (btw i found it by a very fortunate accident while i was searching im Google)

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

Also for the runtime, does you have to call tmdb api for it or trakt provide it itself?

from trakt_ical.

radityaharya avatar radityaharya commented on July 20, 2024

Thanks for your efforts i really appreciate it, and i think this project is fantastic and definitely more users will use it once they find it ;) (btw i found it by a very fortunate accident while i was searching im Google)

Thank you for your kind words! I’m glad you found this project helpful.

Also for the runtime, does you have to call tmdb api for it or trakt provide it itself?

It's provided by Trakt. As far as I know, Trakt is in the process of migrating their metadata from TVDB to TMDB, so it could be a hit or miss for some niche shows/movies. Probably should set a fallback for those that doesn't have a runtime data.

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

It's provided by Trakt. As far as I know, Trakt is in the process of migrating their metadata from TVDB to TMDB, so it could be a hit or miss for some niche shows/movies. Probably should set a fallback for those that doesn't have a runtime data.

Oh, some indeed has approximate runtimes if that's so then i guess it will be resolved soon. :)

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

Awesome, Should i grab a new link or the calendar will update after 8 hours?

from trakt_ical.

radityaharya avatar radityaharya commented on July 20, 2024

Awesome, Should i grab a new link or the calendar will update after 8 hours?

it should pull the latest feed automatically, but you can unsubscribe and resubscribe using the same link if you want to

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

If i resubscribe won't that cache my previous calendar and create another or it will replace the older one according to the trakt account?

from trakt_ical.

radityaharya avatar radityaharya commented on July 20, 2024

If i resubscribe won't that cache my previous calendar and create another or it will replace the older one according to the trakt account?

I'm pretty sure it'll just fetch the latest one. I don't think Google caches feeds within the same url, and the cache I'm using is stored on disk so every time I commit to master it should purge everything as Its being rebuild on Railway

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

Sorry i mean being called on your server, last night i tried an old url from a week ago with old commits and it was still working, i was surprised that it wasn't getting deleted from your server.
What I'm concerned about is that if your server caches old commits and sync them won't that just put a huge load on the server for no good reason?

from trakt_ical.

radityaharya avatar radityaharya commented on July 20, 2024

Sorry i mean being called on your server, last night i tried an old url from a week ago with old commits and it was still working, i was surprised that it wasn't getting deleted from your server. What I'm concerned about is that if your server caches old commits and sync them won't that just put a huge load on the server for no good reason?

The cache should invalidate every hour and fetch new feed from trakt for every request only if the cache haven't expire.

But I might have messed something up and currently the caching doesn't work

from trakt_ical.

MuhammadBayiz avatar MuhammadBayiz commented on July 20, 2024

Man this is awesome!! *0*/
Screenshot_20230722-002532_Calendar
Now even the location is set for the shows! The runtime is mostly right except for movies and the little tweaks are done. Thanks man this is great.
The location doesn't show for movies is that a working progress or a bug? Beside that it feels pretty good

from trakt_ical.

radityaharya avatar radityaharya commented on July 20, 2024

The location doesn't show for movies is that a working progress or a bug? Beside that it feels pretty good

I'm currently using the "Networks" information for the TV Series. TMDB does provide endpoints both for TV and Movies streaming platforms, but as we know availability differs between regions. What i'm planning is to add an additional ui element for users to select which streaming platforms they have access to, sort their priority to be displayed on the calendar and selecting region either from the ui or based on IP geolocation

from trakt_ical.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.