el-patch-validate-all fails on first missing file about el-patch HOT 5 CLOSED

Yes, this seems to fix it. Thanks!

from el-patch.

I solved this with a patch, which protects el-patch-validate with condition-case

--- el-patch/el-patch.el
+++ el-patch/el-patch.el
@@ -13,7 +13,10 @@
           (let ((patch-hash (gethash name el-patch--patches)))
             (dolist (type (hash-table-keys patch-hash))
               (setq patch-count (1+ patch-count))
-              (unless (el-patch-validate name type 'nomsg)
+              (unless (condition-case err
+                          (el-patch-validate name type 'nomsg)
+                        (error (message "%s -> %s" name (error-message-string err))
+                               nil))
                 (setq warning-count (1+ warning-count))))))
         (cond
          ((zerop patch-count)

from el-patch.

I think it would be better to make el-patch-validate signal a warning and return nil, as in other error cases. Can you give me a simple way to reproduce the error, though, so that I can verify the fix works?

from el-patch.

The error happens when I patch a function that does not exist, for example

(el-patch-defun my-non-existent-function ()
  (message "Hello work"))

More typically, I patch a function that exists but is loaded from a compiled lisp file (elc) and the original source file .el does not exists. In my case, my OS (Ubutnu) did not install el files by default for emacs standard packages, only elc files.

from el-patch.

Let me know if this commit fixes it for you.

from el-patch.