Giter Club home page Giter Club logo

Comments (7)

jeremyevans avatar jeremyevans commented on June 10, 2024 1

It is expected that this will no longer work in Rack 3, and I don't think we want to support it, for the same reasons support for non-arrays was dropped. There is no way for Rack to tell the difference between "one\ntwo\three".each_line and network_socket.each_line

from rack.

0x1eef avatar 0x1eef commented on June 10, 2024

Alright - thanks for the quick response !

from rack.

0x1eef avatar 0x1eef commented on June 10, 2024

I extended Rack::ETag to support If-None-Match. Afterwards I saw the performance savings I was hoping for. Sharing here in case it might be useful to anyone else:

class Server::ETag < Rack::ETag
  ETAGS = {}

  def initialize(app)
    @app = app
  end

  def call(env)
    headers = ETAGS[env["REQUEST_PATH"]] || {}
    if headers["etag"] && headers["etag"] == env["HTTP_IF_NONE_MATCH"]
      [304, headers, [""]]
    else
      status, headers, body = super(env)
      ETAGS[env["REQUEST_PATH"]] = headers
      [status, headers, body]
    end
  end
end

from rack.

ioquatix avatar ioquatix commented on June 10, 2024

Not only does that seem like it would leak memory over times, it also looks thread unsafe. Just FYI.

from rack.

0x1eef avatar 0x1eef commented on June 10, 2024

It is for a development server that hosts static files from a local directory. And there is not that many paths. So I'm not too worried about it.

from rack.

MSP-Greg avatar MSP-Greg commented on June 10, 2024

If you're serving static files, why does your example use "one\ntwo\three".each_line for the body?

Or, most would either use the below for the body or an object that responds to to_path?

run lambda { |env| [200, {}, [<file contents>]] }

from rack.

0x1eef avatar 0x1eef commented on June 10, 2024

My goal is to have a development server that supports gzip compression, and caching so that the local environment is similar to nginx. The example was an isolated reproduction for this issue. #to_path might be useful, I might research using it.

from rack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.