Giter Club home page Giter Club logo

Comments (4)

kgoess avatar kgoess commented on September 13, 2024

According to the stomp 1.1 spec http://stomp.github.io/stomp-specification-1.1.html you need to escape colons in your header values by changing them to "\c"

from rabbitmq-stomp.

rauls avatar rauls commented on September 13, 2024

I think the spec should have been a bit more intelligent in the definition, and had an exception if the header value is inside quotes. Like most other specs.... maybe thats why active/apollo took it upon themselves not to be so ruthlessly strict, when logically, HEADER:"content" looks ok to humans.

Sometimes servers should go beyond specs, if specs are not bullet proof. Having said that, yes - its trivial to fix active current client code to adjust if need be.

And specifically, the stomp-js module does this ... and handles this multi colon case.
It would take extra effort to abort the extra colon in this case.

        one_header = headers_split[i].split(':');
        if (one_header.length > 1) {
            header_key = one_header.shift();
            header_val = one_header.join(':');
            these_headers[header_key] = header_val;
        }

from rabbitmq-stomp.

hyperthunk avatar hyperthunk commented on September 13, 2024

We have had a bug open to investigate this issue for a while and we're looking at making our 1.1 parsing more 'permissive' with regards this issue. Feel free to drop by the #rabbitmq channel on freenode if you wish to discuss this further. In the meanwhile, this issue will be closed once we've merged a fix (or decided otherwise). :)

from rabbitmq-stomp.

michaelklishin avatar michaelklishin commented on September 13, 2024

We will try to make header parsing more permissive but according to the spec, it is not a server issue.

from rabbitmq-stomp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.