Setting SSLContext still results in TrustEverythingTrustManager warning about rabbitmq-jms-client HOT 5 CLOSED

Most users probably would expect the same thing: that the trust manager provided in the config would be used. Please submit a PR.

It has been explained multiple times why changing the default trust manager implementation in the Java client is not an easy decision. We wish we could switch to something else without consequences. Unfortunately even after years of improving RabbitMQ TLS guide we see over and over again that a lot of developers have very little clue as to what all those certificates are and what the heck is certificate chain verification. Guess who they take their questions and complaints to and how much they are willing to pay for that time.

from rabbitmq-jms-client.

PR submitted and I do understand why the decision was made the way it was, and I approve of the warning to be there if you are indeed using the TrustEverythingTrustManager however it just makes sense that it shouldn't appear if you aren't actually using it.

It's mainly for when support looks at the logging output of the application, it will prompt questions about why am I not doing it securely when in fact I am.

from rabbitmq-jms-client.

@welsh I understand how that's very annoying and can attract a lot of scrutiny in some environments. @acogoluegnes is away for a few days but I'll try to QA your PR shortly.

from rabbitmq-jms-client.

Ironically this reverses a previous fix made obsolete by the change in the Java client @welsh mentioned.

from rabbitmq-jms-client.

Fixed in #75.

from rabbitmq-jms-client.