Comments (3)
Well, according to the JMS specification, the current behavior is correct, e.g. for JMSPriority
:
When a message is sent, this field is ignored. After completion of the send, it holds the value specified by the method sending the message.
And the Javadoc:
This method is for use by JMS providers only to set this field when a message is sent. This message cannot be used by clients to configure the priority level of the message.
Same thing for expiration and delivery mode.
I suggest we keep this behavior as the default one, but provide a flag to switch to the non-compliant but more natural behavior.
cc @michaelklishin @garyrussell @damonsutherland
from rabbitmq-jms-client.
I concur; I would expect the hierarchy to be
- method argument (in overloaded
send()
)- existing message properties
- producer defaults
- existing message properties
However, it's tough to make a behavior change like that in a maintenance release.
We (Spring) typically handle cases like that with a boolean that retains the previous behavior in the current release and switches to the new behavior in the next release.
That avoids breaking existing apps that are leveraging the current behavior.
from rabbitmq-jms-client.
We can do it in 2.0 or introduce a swappable strategy for property merging.
from rabbitmq-jms-client.
Related Issues (20)
- Implement JMS 2.0 body extraction methods
- Add JMS 2.0 new methods to create a session (JMS_SPEC-45)
- Add new createDurableConsumer JMS 2.0 methods (JMS_SPEC-51)
- Make JMSXDeliveryCount mandatory
- Add flag to enable subscription name validation
- Activate subscription name validation
- Deprecate ConfirmListener in favor of JMS 2.0 asynchronous send
- Support JMS 2.0 asynchronous send HOT 1
- Remove ConfirmListener
- Add support for shared topic subscriptions HOT 1
- Implement JMS 2.0 simplified API
- Bump dependencies
- Bump dependencies
- Support delivery delay
- Support for Queue Selectors
- Request new parameter `nackOnRollback` in `RMQConnectionFactory#createConnectionFactory` HOT 2
- NPE if a received message is marked as "Redelivered" but no header is given HOT 2
- Expose setSaslConfig() on RMQConnectionFactory for supporting Mutual TLS HOT 3
- Bump dependencies
- Bump dependencies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rabbitmq-jms-client.