Giter Club home page Giter Club logo

Comments (3)

acogoluegnes avatar acogoluegnes commented on June 12, 2024 1

Well, according to the JMS specification, the current behavior is correct, e.g. for JMSPriority:

When a message is sent, this field is ignored. After completion of the send, it holds the value specified by the method sending the message.

And the Javadoc:

This method is for use by JMS providers only to set this field when a message is sent. This message cannot be used by clients to configure the priority level of the message.

Same thing for expiration and delivery mode.

I suggest we keep this behavior as the default one, but provide a flag to switch to the non-compliant but more natural behavior.

cc @michaelklishin @garyrussell @damonsutherland

from rabbitmq-jms-client.

garyrussell avatar garyrussell commented on June 12, 2024

I concur; I would expect the hierarchy to be

  • method argument (in overloaded send())
    • existing message properties
      • producer defaults

However, it's tough to make a behavior change like that in a maintenance release.

We (Spring) typically handle cases like that with a boolean that retains the previous behavior in the current release and switches to the new behavior in the next release.

That avoids breaking existing apps that are leveraging the current behavior.

from rabbitmq-jms-client.

michaelklishin avatar michaelklishin commented on June 12, 2024

We can do it in 2.0 or introduce a swappable strategy for property merging.

from rabbitmq-jms-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.