[DEEPLINK][2.1.0] Request to bring back withDeepLink() about compose-destinations HOT 9 CLOSED

Ok.
What do you think of an API like this:

DestinationsNavHost(
    //...
) {
    // next to other "runtime" setup we can have with Compose Destinations
    MyDestination addDeepLink { uriPattern = "URI PATTERN" }
}

You could create an extension function too if you prefer:

public fun ManualComposableCallsBuilder.addDeepLink(destination: DestinationSpec, scheme: DeeplinkScheme) {
    return destination addDeepLink { uriPattern = "${scheme.value}://${destination.route}" }
}

But you would need to call it inside the DestinationsNavHost trailing lambda.

Haven't even tried to code this, but just from the top of my head, it should be possible.

from compose-destinations.

Hey 👋

So essentially you need to be able to set deep links at runtime. The problem is not where it is set, since there's ways to override things like deep links when importing destinations or graphs. The problem is that you cannot use annotations coz those can only take constants.

Is that it?

from compose-destinations.

Yes, that's exactly the problem.

from compose-destinations.

I think that will solve our problem, but tbh, I would prefer to be able to add it to the destination instead, so everything can be together on the graph.

from compose-destinations.

Just realized that by doing your approach we can start generating instead of building our owns.

from compose-destinations.

So, is that good or bad? I'm not sure I understand what you mean 🤔

from compose-destinations.

It's better. We had to have the custom graphs just to include deeplinks, by using that approach it will be not necessary because the deeplinks will be added to the DestinationsNavHost trailing lambda.

from compose-destinations.

Ahh, yes. With v2 there should be no reason for implementing NavGraphSpec of core library manually.

from compose-destinations.

Went with above approach. It is included in beta07 that is currently building, so probably up in about 30min or so.
That version will also contain your PR changes (thanks for that! 🙏 )

from compose-destinations.