Giter Club home page Giter Club logo

Comments (5)

boktai1000 avatar boktai1000 commented on June 18, 2024 1

Unfortunately after running 3.4.1 and wiping the slate clean in SavedVariables, running a /gldev build & /reload as well as a /gldev purge & /reload both outcomes land with Lua error bombs :(

Can be replicated with a fresh setup of GetLinkWOTLK_341.zip

Reviewing the commits, it seems like the itemID was increased, but lots of addons broke in 3.4.1 - I won't claim to know what changes happened under the hood but I think it's something a bit deeper than a few new items, if that helps any

from getlink-tbc.

boktai1000 avatar boktai1000 commented on June 18, 2024 1

Seems to be working now!! Thank you so much for looking further and for allowing this addon to continue working into Wrath!

from getlink-tbc.

r0ska avatar r0ska commented on June 18, 2024

Updated the addon for Ulduar (3.4.1) patch. If you're still getting errors, try running /gldev purge & then /reload

from getlink-tbc.

r0ska avatar r0ska commented on June 18, 2024

I think I found the problem.

(*temporary) = "attempt to index global 'GLTable' (a nil value)"
(*temporary) = "table expected, got nil"

(╯°□°)╯︵ nil

I've made rookie mistake when "updating" this addon from TBC to WOTLK. One argument in WOTLK version was still referring to TBC; that's why GLTable never got initialized. Sadly I only did testing with my non-fresh setup 😭

if event == "ADDON_LOADED" and arg1 == "GetLinkTBC" then
	if not GLOptions or GLOptions["Version"] ~= nVersion then
		GLTable = {}
		...
		...

from getlink-tbc.

r0ska avatar r0ska commented on June 18, 2024

Minifix is out! https://github.com/r0ska/getlink-tbc/releases/tag/getlink-wotlk-341-minifix

I've changed arg1 to wotlk one + made new github release. Hopefully this fixes the problem!

If not; hit me up and i'll investigate more tomorrow when my brain is less dead.

from getlink-tbc.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.