Giter Club home page Giter Club logo

Comments (156)

petrosh avatar petrosh commented on May 13, 2024 7

Patches!!

from spacex-api.

quadrplax avatar quadrplax commented on May 13, 2024 6

https://api.spacexdata.com/upcoming
Info for next three or so launches which have solid-ish NET dates.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 4

Patch links are now live! πŸ‘

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 4

@TrueRGB Added to all past and upcoming flights πŸ‘ Should be live

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 3

@jokecamp Looking at a better way to express the data, so it allows for more flexibility going forward.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 3

I agree with @jeroenboumans that endpoints with an ID should only return the object needed. The Launchpad endpoint is the only one not following this, but should be a trivial fix.

@waterskier2007 I'll add routes with ID's for cores/caps

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 3

Changes are live @waterskier2007 @jeroenboumans

https://api.spacexdata.com/v2/parts/cores/B1041
https://api.spacexdata.com/v2/parts/caps/C113
https://api.spacexdata.com/v2/launchpads/ccafs_slc_40

Adding 404's for bad ID's shortly

from spacex-api.

TrueRGB avatar TrueRGB commented on May 13, 2024 3

Yes, some mission name ideas:

  • Flight-56 ----- Paz / Starlink Demo
  • Flight-54 ----- SES-16 / GovSat-1
  • Flight-47 ----- Boeing X-37B OTV-5
  • Flight-31 ----- ABS-2A / Eutelsat 117W B
  • Flight-25 ----- OG-2 Mission 2
  • Flight-21 ----- ABS-3A / Eutelsat 115W B
  • Flight-15 ----- OG-2 Mission 1
  • Flight-6 ----- Falcon 9 Test Flight

I'm sure someone can come up with better names for the missions, it's difficult because some of them don't really have an official name. A mission_name would be more of a convenience than a necessity, but it would be nice either way.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 2

@jokecamp @HarvsG Now that I have a good way to add multiple links, I'll make a pass and add the reddit launch threads

Anything else media related that should be included?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 2

Launches + Upcoming Launches now have links to reddit campaign, launch, recovery, and media threads, as well as official presskit PDF's put out by SpaceX πŸ‘

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 2

Adding sorting support in #65

Edit: @jeroenboumans Sorting support is now live for past and upcoming launch endpoints using the following querystrings

order=asc for ascending order
order=desc for descending order

from spacex-api.

rafaelramalho19 avatar rafaelramalho19 commented on May 13, 2024 2

We should be able to fetch a certain launch information regardless of knowing it's from the past or an upcoming launch. Here's a PR with the fix πŸŽ‰ #74

from spacex-api.

TrueRGB avatar TrueRGB commented on May 13, 2024 2

Hey!

I recently started using this API, and I noticed that the only way to get the "name" of the mission was to use the payload ID. This isn't optimal since some of the payload IDs are very long and some don't really match what the mission was called. For example, "Falcon Heavy Test Flight" would be more fitting than just "Tesla Roadster".

Is there any way a mission_name could be implemented in the API, or am I just missing something?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 2

@sebbekarlsson Few sources, mostly the following:

  1. https://www.reddit.com/r/spacex/wiki/index
  2. https://en.wikipedia.org/wiki/List_of_Falcon_9_and_Falcon_Heavy_launches
  3. https://spaceflightnow.com/

Launch updates sometimes come from Elon or SpaceX's twitter pages too

from spacex-api.

jokecamp avatar jokecamp commented on May 13, 2024 1

It would be great to make links an array in a hypermedia inspired way. That way you could link a lot of different links like SpaceX instagram posts, gifs, videos, articles,

Something like

links: [ { type: 'video', url: '' }, { type: 'instagram', url: '' }, ]

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024 1

@jakewmeyer you are the man

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024 1

Thanks for the quick update @jakewmeyer! Will update my app tonight! πŸ‘

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 1

@garyjacobs Went through and corrected the non https links πŸ‘

Interesting that they don't preserve the transparency at smaller sizes

from spacex-api.

garyjacobs avatar garyjacobs commented on May 13, 2024 1

Cheers for the image URL updates. πŸ‘

Turns out the transparency being stripped is by design from imgur. If a png is over a certain size it gets converted to jpg.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 1

@maxxm2017 Information is added as soon as it becomes available, and a good portion of it isn't available until the day or two before the launch.

from spacex-api.

maxxm2017 avatar maxxm2017 commented on May 13, 2024 1

@jakewmeyer, appreciate the information. Was looking at it the day before the Bangabandhu-1 mission and the data wasn't there. Now it was supposed to launch yesterday (scrubbed to today), but still no mission detail information ,etc. I do see that the patch has been updated, along with some other data! Again, total noob so sorry if they're nonsense questions. Was hoping that mission detail information would be available a bit earlier, but I understand that it posts when it becomes available. Thanks for all the great work!

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024 1

@alshapton Previously I've added most of these changes myself, usually through json files submitted and subsequently added to the database. Only thing that would need to change in the code is adding to the tests to check for the presence of the additions, and adding it to the query string launch query builder.

As long as we're not removing anything, it should be a non breaking change πŸ‘

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024 1

Thanks @jakewmeyer, just created the issue in #89

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024 1

@samcat116 yep, that was the direction I was thinking about in my last post. Think we're on the same line here :) πŸ‘

from spacex-api.

samcat116 avatar samcat116 commented on May 13, 2024 1

So I guess what @jakewmeyer was originally thinking would work best. Might be better to not serve the largest size by default though.

from spacex-api.

samcat116 avatar samcat116 commented on May 13, 2024 1

@jakewmeyer I think the ' -b ' size would make sense in most situations. I think thats 1024 on the longest side.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

Planning on adding tentative future launch data next.

Thanks for the feedback!

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

Agreed on the patches 200% πŸ‘

Links to the original photos?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@quadrplax I've added an endpoint for upcoming launches, I'll keep adding to it as we find out information.

https://api.spacexdata.com/launches/upcoming

from spacex-api.

HarvsG avatar HarvsG commented on May 13, 2024

Not exactly sure of the usefulness, but perhaps links to Reddit launch threads and/or media threads? Perhaps as part of @jokecamp's suggestion for a 'links' object

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@HarvsG I'll add it to the list for the links object

from spacex-api.

kfarr avatar kfarr commented on May 13, 2024

This is a great data source, thanks for creating this! Curious if there is source for add'l info on the launches -- specifically looking for detailed info to create a 3d visualization of the launches.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@kfarr What kind of additional info?

from spacex-api.

kfarr avatar kfarr commented on May 13, 2024

So the crazy idea is to make a visualization of the earth and the orbit in webvr. This would require at a minimum:

  • Launch site geo position (available now)
  • Landing site geo position (for 1 or more components)
  • Flight path - even a basic approximation

I don't know the right way to suggest providing this data but I think there would be interest in such a visualization and I'm happy to take a stab at it.

I suppose the "pareto superior" next step is to provide a landing position in addition to launch site in the data?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

Awesome! I've been wanting to include more detailed telemetry, but haven't had a good way to make it happen easily until now. If we can nail down some specific info that we need, I can add a telemetry section to the flights for easier visualization and analysis.

The idea almost sounds like a VR version of Flight Club from @murphd37, which has super detailed trajectory and data simulations for lots of flights. He would be a good resource for information about the best way to go about it.

from spacex-api.

kfarr avatar kfarr commented on May 13, 2024

Wow Flight Club is incredible, looks like @murphd37 has done the heavy lifting already on the visualization side. So, the missing element is simply linking these together? For example, here's the link to the "playback" view of Bulgaria Sat 1: https://www.flightclub.io/world/?w=2&code=BGS1

It could be yet another item in the link array, assuming that there is interest in visualizing these things ahead of the mission launch. I also don't know what info is released publicly prior to launch

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

I'll make a pass on the database and add the links for the launches @murphd37 added previously πŸ‘

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

Here's an idea for the rocket associated to each launch

Similar to how the launches have the launch site as:

"launch_site": {
"site_id": "kwajalein_atoll",
"site_name": "Kwajalein Atoll"
}

You could have the rocket for each launch like:

"rocket": {
"rocket_id": "falcon9",
"rocket_name": "Falcon 9"
}

This would allow lookups of rockets from the launch data

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

@jakewmeyer thoughts?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@waterskier2007 I'll add it to the list, hoping to add this and #31 today/tonight

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

πŸ‘Œyou da man

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

@jakewmeyer I see some of the launches are beginning to take the structure. I assume your plan is to do this for all launches?

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

@jakewmeyer also, just an FYI, the launches/cores/coreId and launches/caps/capId endpoints will have to be updated because the core_serial and cap_serial are no longer properties of the launches directly

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@waterskier2007 I was fighting with the endpoints last night, and the query wasn't working as it should. So I just moved the serial numbers back out to the root of the object, so the endpoints don't have to be changed.

Everything should be updated at with the rocket name + info at this point πŸ‘

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@waterskier2007 That's what I was trying to do, but translating it to Ruby syntax wasn't working properly. I'm pretty sure you can use the dot notation syntax or this style, but neither would work for me.

collection.find(rocket: {core_serial: "#{core}"}, projection: {_id: 0}).sort(rocket: {core_serial: 1})

or

collection.find({'rocket.core_serial': "#{core}"}, projection: {_id: 0}).sort('rocket.core_serial': 1})

In both cases it would work without the projection and sorting statements. Planning on taking another crack at it to see if I can make it work.

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

@jakewmeyer what is the projection necessary for? It seems like it's only to limit the fields returned, but wouldn't you want all of the fields?

again, my ruby knowledge here is mostly nil but I was just looking at the documentation here https://docs.mongodb.com/manual/reference/method/db.collection.find/

from spacex-api.

gravitylow avatar gravitylow commented on May 13, 2024

Does it make sense to sort launches by date by default?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@gravitylow What do you mean?

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

I agree with sorting/ordening. Could be useful to set a param in the api call, like so: ".../launches?order=desc".

Also I'd love to see some more mission details, like a title and maybe some meta data? For example the IRIDIUM-4 MISSION doesn't have a patch-image url right now. Launch is within 16 hours. Also the title Iridiium-4 isn't mentioned in any details yet:

...
"links": {
  "mission_patch": null,
  "reddit_campaign": "https://www.reddit.com/r/spacex/comments/7cgts7/iridium_next_constellation_mission_4_launch/",
  "reddit_launch": null,
  "reddit_recovery": null,
  "reddit_media": null,
  "presskit": null,
  "article_link": null,
  "video_link": null
},
"details": null
...

Update: I've also noticed the 23 dec launch of Iridium isn't updated. Would it help to have some people update the data?

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

The launchpad by ID should not return an array

example: https://api.spacexdata.com/v2/launchpads/ccafs_slc_40

Also, there should be the ability to get cap/core based on serial directly as a route param like above, not as a query parameter

from spacex-api.

jhpratt avatar jhpratt commented on May 13, 2024

@waterskier2007 I imagine the first part of that should be trivial to change by adding [0] to wherever the endpoint is defined.

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

@jhpratt that would be the workaround indeed. Though, I agree with @waterskier2007, an endpoint with an ID (not a param or search term) should return a single object. This is fixed for the capsule and rocket endpoints in #68.

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

@jhpratt Yeah I know the workaround, it's just more about consistency and following closer to a normal REST standard

@jeroenboumans any reason that it's fixed for capsules but not for cores?

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

@jhpratt I'm not sure. Best is to ask @jakewmeyer :)

from spacex-api.

waterskier2007 avatar waterskier2007 commented on May 13, 2024

yeah, it looks like it works for capsules but not for detailed capsules... seems like an inconsistency in my book

see here: https://github.com/r-spacex/SpaceX-API/wiki/Capsule-Detail

@jakewmeyer

from spacex-api.

jhpratt avatar jhpratt commented on May 13, 2024

Proposed addition: block of each core.

This should be an easy one to add, given we can find enough data.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

Saw that @jhpratt. Should be able to add to to launches and detailed core data

from spacex-api.

ahatzz11 avatar ahatzz11 commented on May 13, 2024

First - awesome API! I’ve been having a lot of fun playing with this.

Second - I found a few unexpected ways of how the resources are managed and I think there could be some improvements for REST resources.

I expected to be able to get a specific launches info based on it’s ID (flight_number) as a resource through the path, e.g. https://api.spacexdata.com/v2/launches/58 would return the information for flight 58. This is possible as a query param, e.g. https://api.spacexdata.com/v2/launches?flight_number=58, but accessing the resource for flight 58 via the path seems to follow REST.

Continuing on, I also expected that the /launches resource would have all the launches. As of now I’m not able to get a future launch through this endpoint, e.g. https://api.spacexdata.com/v2/launches?flight_number=59 returns an empty array.

sidenote: I noticed the docs mention that an empty array is returned if no match is found through querystring filtering. If the API moved to the resource being found through the path, that could return a 404 if the resource wasn’t found.

It would be a big change to the current contract, but /launches containing all launches and /launches/all being replaced with /launches/past would be great. I see the second path param adding the ability to narrow down the results:

  • launches/upcoming
  • launches/past
  • launches/latest

I'm working on a PR to make some of these changes to see how it would work - still learning how to build/test locally.

Thanks for making this awesome API!

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

Glad you're enjoying it @ahatzz11 ! πŸ‘

  1. Not opposed to making it more in line with REST, but moving the resource filtering to query strings made it easier to handle edge cases and crazy filtering options people were looking for.

sidenote: This was a big point of debate for awhile, but it makes sense not to return 404, because the resource(aka. collection) is technically found, but no results were found.

  1. https://api.spacexdata.com/v2/launches?flight_number=59 returns flight 59 for me, not an empty array

  2. Originally launches held ALL the launches, but the upcoming ones were moved to a new collection for better separation of responsibility. This would be a major breaking change in the way the launches are currently delivered.

from spacex-api.

ahatzz11 avatar ahatzz11 commented on May 13, 2024
  1. The query filtering could stay in place, and getting a resource of a flight by ID could be an addition. Although a case like https://api.spacexdata.com/v2/launches/58?flight_number=58 might be weird if the path parameter didn't line up with the query parameter.

  2. When I wrote the comment yesterday with the flight 59 example, it didn't exist. Then SpaceX had their Falcon 9 launch yesterday and made my comment out of date! Hard to keep up with so many launches nowadays πŸš€

    An example that shouldn't go out of date soon: https://api.spacexdata.com/v2/launches?flight_number=100 returns an empty array.

  3. Interesting point here. I'll have to look more closely at how that's being managed.

Thanks for the speedy response here! (and on issue #82 regarding failing tests)

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024
  1. Sounds good! Should make it more RESTful going forward.

  2. Gotcha πŸ‘

  3. We might be able to figure out a better name option while preserving backwards compatibility.

from spacex-api.

garyjacobs avatar garyjacobs commented on May 13, 2024

Hey Jake,
Thanks for this sweet API!

I was just wondering, with the mission patches, if it would be advantageous to have them in 2 sizes. The large size they are currently in and a smaller size - maybe half or more.

I'm having performance issues in scrolling a UICollectionView that is displaying a thumbnail of the images (which are actually rendered as full res and scaled down)

Not sure anything can be done but it's a long shot request.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

Hey Gary! Glad you like it πŸ‘

Shouldn't be a long shot request, since imgur photos can be served in multiple sizes by modifying the end of the url.

Looks like the original ones are 924 x 868 https://i.imgur.com/eHxbiG3.png
You can add a l, m, or s to the url to make it smaller.

For example: https://i.imgur.com/eHxbiG3m.png is 320 x 301, which is considerably smaller.

If we can decide what size is best for a smaller image, I'll add a mission_patch_small field with the corrected url πŸ‘

from spacex-api.

garyjacobs avatar garyjacobs commented on May 13, 2024

Hey Jake!
I didn't know that IMGUR had that feature. In theory that would be awesome and the "m" size would be perfect but it looks like most of the non-full version don't have a transparent background. They render with either black or white squares. (See image attached)

The full version is the only one that has the transparency around the patches. So I appreciate the willingness to add the end point and it would have been a sweet solution but I don't think it would be worth your time (for my needs anyway).

I'll just save the mission patch image for the detail view of the app πŸ‘

Thanks again πŸš€

images

P.S. - I'm not sure what is going on with the 's' sized ones but most of them have been cropped. so it's not even the same image as the others. Weird πŸ€·β€β™‚οΈ

from spacex-api.

garyjacobs avatar garyjacobs commented on May 13, 2024

Hey Jake,
Just a small one I found and I'm not sure if it matters but the the following flight mission patches have an http instead of an https

35 - http://i.imgur.com/4zo17M6.png
36 - http://i.imgur.com/6Ykkq2B.png
38 - http://i.imgur.com/BzYVR9F.png
39 - http://i.imgur.com/nAzU032.png

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@TrueRGB Sure!

Like you mentioned, sometimes the payload doesn't always line up with the colloquial "mission name". Are there any other special cases that don't make sense to you?

Just want to make sure we're on the same page with what the names should be πŸ‘

from spacex-api.

maxxm2017 avatar maxxm2017 commented on May 13, 2024

Thanks for all the great info! I'm very new to this, but want to start experimenting for an idea I have utilizing this data. Is there something (or can you add) some more detailed info for the next upcoming launch? For example, the "latest launch" information is fantastic for the most recent launch (patches, mission description, etc.), but the "upcoming" launches all seem to have Null for this information (even for Bangabandhu-1 which is currently scheduled to launch tomorrow), I would think this would have some more info? Maybe I'm missing something?

Thanks for the help!!

from spacex-api.

psidex avatar psidex commented on May 13, 2024

@maxxm2017 What have you tried? https://api.spacexdata.com/v2/launches/upcoming?order=asc will give you the next upcoming launches, in ascending order, and contains all the information known about the launches

from spacex-api.

maxxm2017 avatar maxxm2017 commented on May 13, 2024

Yes sir I did use that. I'm speaking specifically to the bottom of each launch section is null for a lot of it (except for reddit campaign thread):

mission_patch":null,"mission_patch_small":null,"reddit_campaign":"https://www.reddit.com/r/spacex/comments/8624iq/bangabandhu1_launch_campaign_thread/","reddit_launch":null,"reddit_recovery":null,"reddit_media":null,"presskit":null,"article_link":null,"video_link":null},"details":null},

from spacex-api.

trimeta avatar trimeta commented on May 13, 2024

For Falcon Heavy missions, is the center core guaranteed to be the first element of the rocket.first_stage.cores section? If not, how can we reliably pull data from the center core for Heavy missions?

from spacex-api.

jonghough avatar jonghough commented on May 13, 2024

It would be nice to get some images, either photos or diagrams of each of the rockets, in the API.
For example

{"id":"falcon9",
 "name":"Falcon 9",...
 "link_to_img":"https:// ... .png
}

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

@jakewmeyer, I agree to the fact that a bit more deeper information can be added to the API, for example on the About SpaceX API call. Based on comparing the API endpoint to the spacex website the timeline could be a nice addition to the API endpoints, for example /v2/info/history. In other words more detailed information on sub-endpoints.

@jonghough, However adding images/visuals is application dependent. As I'm building a SpaceX companion app at the moment I'm hosting the images myself using prefixes in the image names like falcon9_ of falconheavy_. These can be linked via vehicle IDs. I personally think the API should provide only structured structural information.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@trimeta Yes, the center core is guaranteed to be the first element in the array.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@jeroenboumans History on the API? Or history on SpaceX?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@jonghough Not opposed to the idea, since we do provide image links for patches and such. However, keep in mind that you might need different sized photos on different platforms.

Like @jeroenboumans suggested, bringing your own photos and linking them to information in the API might be the better solution, so you can custom fit your images to your specific application.

If you still want me to add it, we can decide on some standardized images and go from there πŸ‘

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

@jakewmeyer the history of SpaceX which can be found in the Making History section. Would be nice if this could be added :)

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@jeroenboumans Any opinions on the best way to structure it?

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

Hi @jakewmeyer ,

I'd say use a format like this:
An event model containing data like: title, event date (yyyy-mm-dd), description, original blog url/reddit url about the event. All sortable by date (ASC/DESC), probably groupable by year like the timetable on spacex.com. Maybe add categories, or vehicles IDs concerned to the event used for filtering.

  • /v2/info/history returning all history for now
  • /v2/info/history?year=2018 returning events for a specific date/year
  • /v2/info/history?year=2018&order=asc returning events for a specific date/year ordered (asc or desc)
  • /v2/info/history?rocketid=falcon9 returning all events for a specific rockettype

Just some quick endpoints I'm thinking of.

Looking forward if something like this could be added! :) πŸ‘

from spacex-api.

alshapton avatar alshapton commented on May 13, 2024

Two ideas here:
i) would there be any value in building up a set of dates when launches were delayed ? i.e. if the launch is delayed, then the original date is stored as a separate property, and the new date is included. Should that date be delayed again, it should be shuffled down further....... e.g:

"launch_date_utc": "2018-05-15T20:14:00Z",
{"delayed_launches": [
"2018-05-12T06:17:00Z",
"2018-04-19T21:22:00Z"
]
}

ii) in preparation for the crewed launches, space for the crew names, and maybe in time, other information:

"crew": [
{
{
"commander": "Robert Louis Behnken",
"links": {
"wikipedia_bio": "https://en.wikipedia.org/wiki/Robert_Louis_Behnken",
}
},
{
"co-pilot": "Sunita Williams",
"links": {
"wikipedia_bio": "https://en.wikipedia.org/wiki/Sunita_Williams"
}
}
{
"engineer": " Douglas Hurley",
"links": {
"wikipedia_bio": "https://en.wikipedia.org/wiki/Douglas_Hurley"
}
}
]
........ etc

Thoughts ?

I'd be happy to have a bash at one or both of these if there's a call for them.....

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

@alshapton I don't think the delayed_launchdates can be used for expanding more information about the launch. I do think a log with information about the flight in general can be more interesting. For example checkout the Timeline section on this reddit topic (which had a delayed launch). As we can see in that example, the delayed launch time is just an event on the full launch log. @jakewmeyer interesting enough for the API?

@alshapton I like the idea about showing crew members in the API data :) πŸ‘In the future that could mean it is possible to select all flights of a crew member or something like that.

from spacex-api.

alshapton avatar alshapton commented on May 13, 2024

@jeroenboumans I'll have a crack at the crew stuff.... πŸ‘

from spacex-api.

alshapton avatar alshapton commented on May 13, 2024

Adding to my previous comment (probably directed @jakewmeyer here) - I'm looking to modify the schema of the db - I can do that in a dev environment, however, how should I submit that for inclusion in the change request, such that the schema change will go along with the code (bearing in mind it should be a non-breaking change ?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@jeroenboumans Go ahead and add a new issue for the history data, and we can get started on it

from spacex-api.

sebbekarlsson avatar sebbekarlsson commented on May 13, 2024

Where are you getting the data from? @jakewmeyer

from spacex-api.

dnjef avatar dnjef commented on May 13, 2024

Probably the wrong place, but consider transferring the current backend to TypeScript

It's a superset with types.

I could make a pull request with the current backend running on typescript?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@CPP-MASTERRACE Considered it in the past, but I think it would just add an unnecessary amount of overhead and complexity for a small project like this, especially for new people who might not know TypeScript but still want to contribute.

from spacex-api.

dnjef avatar dnjef commented on May 13, 2024

@jakewmeyer IMO it really wouldn't add any complexity or overhead, just make the code more readable and structured. The syntax is basically the same (with types). If you have slack or gitter I could show you a really well structured API and if you don't understand it within 5 minutes you've proven your point.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@CPP-MASTERRACE If you're up for it, feel free to submit the PR πŸ‘

from spacex-api.

samcat116 avatar samcat116 commented on May 13, 2024

Any way you could easily add more launch photos from the official SpaceX Flickr? They seem to upload photos pretty quickly after a launch. Unfortunately they don't separate each launch into a separate album, but you could just serve all the URLs for the various photos for a certain launch.
Also not sure how the Flicker API works in terms of photo sizes.

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@samcat116 I can, but we would need to decide on the best size image to use for the links. It could look something like this.

{
  "launch_photos": [
    "https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_k.jpg",
    "https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_k.jpg",
    "https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_k.jpg",
    "https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_k.jpg"
  ]
}

from spacex-api.

samcat116 avatar samcat116 commented on May 13, 2024

Do we want to give the largest size by default? Maybe the normal size is more appropriate.

{
  "launch_photos": [
    "https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_b.jpg",
    "https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_b.jpg",
    "https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_b.jpg",
    "https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_b.jpg"
  ]
}

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

@samcat116 @jakewmeyer how about serving an image object per launch photo containing the sizes like this?

{
    "launch_photos": [
        {
            "xsmall":"https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_b_1.jpg",
            "small":"https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_b_2.jpg",
            "medium":"https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_b_3.jpg",
            "large":"https://farm1.staticflickr.com/911/42025499722_ded6ed7d74_b_4.jpg"
        },
        {
            .... // more photo objects
        }
  ]
}

from spacex-api.

samcat116 avatar samcat116 commented on May 13, 2024

@jeroenboumans @jakewmeyer That would work fine, just would be a lot of links. I would also add the thumbnail size to the four you already have.

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

@samcat116 I guess I was a little rash in my response. Flickr does indeed support sizes like mentioned here.
I think specifying the Uri only would indeed work since their image url format works like this: http://www.flickr.com/photos/USER/PHOTO/sizes/SIZE.

from spacex-api.

samcat116 avatar samcat116 commented on May 13, 2024

I was looking at the format here. I think that specifying only a single size would work, that way each launch would only have like 12 links, instead of like 48. Plus people can always change the link to get the size they want.

from spacex-api.

jeroenboumans avatar jeroenboumans commented on May 13, 2024

I've also added #93 , a request for adding the BFR specs to the rockets overview :)

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@samcat116 What size works best as a middle ground?

from spacex-api.

jakewmeyer avatar jakewmeyer commented on May 13, 2024

@samcat116 Doesn't look like the -b option will work for most of the photos. Flickr keeps returning the image as unavailable when using it

from spacex-api.

TsaiZinan avatar TsaiZinan commented on May 13, 2024

Thanks for your API. It helps me a lot in learning web.
I found that the URLs of mission_patch and mission_patch_small in flight 48 (Iridium NEXT Mission 3) are the same which present as the large size image.

from spacex-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.