Improve col_factor's handling of color brewer palettes about scales HOT 8 CLOSED

Maybe it should use brewer_pal()?

from scales.

Yeah, perhaps.

from scales.

I don't have the time for this, but I'd review a PR.

from scales.

Not sure why this is closed; col_factor with a qualitative color brewer palette is really broken. For example with show_col(col_factor("Set1", levels = 1:4)(1:4)) only one of the resulting colors is actually in Set1. Unfortunately the breakage propagated to leaflet::colorFactor as well.

from scales.

If brewer_pal() is used instead of interpolation, you lose the ability to generate more colors than the palette provides. This may break compatibility when someone was using col_factor to generate more colors than the palette provides.

from scales.

Would it be possible to use interpolation only in the case where the number
of colors is more than the palette provides?

On Tue, Sep 27, 2016 at 1:57 PM, Bhaskar V. Karambelkar <
[email protected]> wrote:

If brewer_pal() is used instead of interpolation, you lose the ability to
generate more colors than the palette provides. This may break
compatibility when someone was using col_factor to generate more colors
than the palette provides.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#62 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AALamZnf_oQ7BEBqmM7ZIEg3c73AqwfKks5quVj1gaJpZM4FOCtA
.

from scales.

That's what I was thinking. And it may even be a good idea to warn if interpolation is required.

from scales.

rstudio/leaflet#364

from scales.